Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#18 shortcut-1978970-18.patch7.61 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,005 pass(es).
[ View ]
#18 interdiff.txt621 bytestim.plunkett
#12 shortcut-1978970-12.patch7.61 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,438 pass(es).
[ View ]
#12 interdiff.txt2.57 KBtim.plunkett
#10 shortcut-1978970-10.patch7.05 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#8 shortcut-1978970-8.patch6.82 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 57,995 pass(es).
[ View ]
#2 shortcut-1978970-2.patch6.35 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch shortcut-1978970-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Assigned:Unassigned» tim.plunkett

Might be interesting.

Status:Active» Needs review
StatusFileSize
new6.35 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch shortcut-1978970-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work
Issue tags:-FormInterface

The last submitted patch, shortcut-1978970-2.patch, failed testing.

Status:Needs work» Needs review

#2: shortcut-1978970-2.patch queued for re-testing.

#2: shortcut-1978970-2.patch queued for re-testing.

#2: shortcut-1978970-2.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+FormInterface

The last submitted patch, shortcut-1978970-2.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new6.82 KB
PASSED: [[SimpleTest]]: [MySQL] 57,995 pass(es).
[ View ]

Reroll

Status:Needs review» Needs work

+++ b/core/modules/shortcut/lib/Drupal/shortcut/Controller/ShortcutController.php
@@ -27,26 +39,58 @@ class ShortcutController implements ControllerInterface {
+      drupal_goto();

This function has been expunged. Return an appropriate redirect object instead.

Status:Needs work» Needs review
StatusFileSize
new7.05 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Had to reroll anyway, the drupal_goto was swapped out for return new RedirectResponse(url('<front>', array('absolute' => TRUE)));

url()? No generator? Generator please. :-)

StatusFileSize
new2.57 KB
new7.61 KB
PASSED: [[SimpleTest]]: [MySQL] 58,438 pass(es).
[ View ]

Yeah yeah :)

Issue tags:+WSCCI-conversion

Taggin.

Status:Needs review» Needs work
Issue tags:-FormInterface, -WSCCI-conversion

The last submitted patch, shortcut-1978970-12.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+FormInterface, +WSCCI-conversion

#12: shortcut-1978970-12.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Thank you. :-)

Status:Reviewed & tested by the community» Needs review

+++ b/core/modules/shortcut/shortcut.routing.ymlundefined
@@ -25,3 +25,10 @@ shortcut_set_edit:
+    _content: 'Drupal\shortcut\Controller\ShortcutController::addShortcutLinkInline'

_controller is probably enough, as we just redirect.

StatusFileSize
new621 bytes
new7.61 KB
PASSED: [[SimpleTest]]: [MySQL] 58,005 pass(es).
[ View ]

Made that change

Status:Needs review» Reviewed & tested by the community

Bot can disagree if it wants.

back to RTBC

Status:Reviewed & tested by the community» Fixed

Committed 4852362 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.