Convert this page callback to a new-style Controller, using the instructions on WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#5 drupal-1978980-5.patch4.46 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,801 pass(es).
[ View ]
#5 interdiff.txt1.15 KBdawehner
#3 drupal-1978980-3.patch4.46 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,392 pass(es).
[ View ]
#3 interdiff.txt1.67 KBdawehner
#1 drupal-1978980-1.patch3.71 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,770 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.71 KB
PASSED: [[SimpleTest]]: [MySQL] 55,770 pass(es).
[ View ]

There we go.

+++ b/core/modules/toolbar/toolbar.moduleundefined
@@ -59,20 +59,6 @@ function toolbar_theme($existing, $type, $theme, $path) {
-    'page callback' => 'toolbar_subtrees_jsonp',

i cant see this callback deleted.is it used elsewhere?

+++ b/core/modules/toolbar/toolbar.moduleundefined
@@ -130,7 +116,7 @@ function toolbar_element_info() {
function _toolbar_subtrees_access($hash) {

any reason you kept this?:)

StatusFileSize
new1.67 KB
new4.46 KB
PASSED: [[SimpleTest]]: [MySQL] 55,392 pass(es).
[ View ]

Thanks for the review!

I wanted to keep the patch as small as possible, just kidding ;)

haha, smaller patches, easier to review:P

+++ b/core/modules/toolbar/lib/Drupal/toolbar/Routing/ToolbarController.phpundefined
@@ -0,0 +1,30 @@
+  public function subtreesJSONP() {

nitpick time then: i am not 100% sure about the naming of this method.shouldn't it be sunbtreeJsonp :)

StatusFileSize
new1.15 KB
new4.46 KB
PASSED: [[SimpleTest]]: [MySQL] 55,801 pass(es).
[ View ]

There we go.

Status:Needs review» Reviewed & tested by the community

looks great now, thanks!

Status:Reviewed & tested by the community» Fixed

Committed a5e363a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.