Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ilyna’s picture

FileSize
27.33 KB
Ilyna’s picture

FileSize
1.89 KB

Error in patch file

krystlc’s picture

#2 patch still works but i had to patch it manually.

intergalactic overlords’s picture

Issue summary: View changes
FileSize
1.83 KB

Re-uploaded the patch. The path inside the patch was from root. Can now be applied automatically from inside the module folder.

intergalactic overlords’s picture

Status: Active » Needs review

Re-uploaded the patch. The path inside the patch was from root. Can now be applied automatically from inside the module folder.

jaxxed’s picture

That last patch looks like a re-package. I properly packaged the above changes from the latest 7.x-1.x git branch as per patch submission requirements. This fixes the git --diff line at the top of the patch.

I took only 1 or two liberties in cleaning the code. The language helper function that returns the SQL condition for the language was pretty messy (extra semi-colon, double return, no validation on node language.) The modules could still use more SQL validation and should like use more db_select() instead of db_query().

I am not sure what impact the patch has/should have on the hook_cron() task.

Instructions for providing a patch to a Drupal project: https://drupal.org/node/707484

Sebb'a’s picture

#6 patch has a bug in the first fixed line
+ $cond = _prev_next_node_types_sql($node_type) . _prev_next_node_lang;

you have to put ($nid) behind _prex_next_node_lang:
+ $cond = _prev_next_node_types_sql($node_type) . _prev_next_node_lang($nid);

Jorge Navarro’s picture

Tested with #7 fix, it works!

marty.true’s picture

Status: Needs review » Patch (to be ported)

Where does this issue/patch stand now that the module is in 7.x-2.x-dev and 7.x-1.x-dev is no longer supported?

ckng’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Assigned: Ilyna » Unassigned
Status: Patch (to be ported) » Needs review
FileSize
1.72 KB

A new patch for 7.x-2.x.