this would allow for yet more space to be saved
as for tables with more than 50 rows too much scrolling will be needed

or on a more advanced level fields could become editable on clicking on them

In general the project is a good approach but perhaps looking and/or collaborating with any of the following projects will be a win for the community
http://drupal.org/project/jeditable
http://drupal.org/project/editablefields
http://drupal.org/project/jqgrid
http://drupal.org/project/slickgrid
http://drupal.org/project/edit (part of drupal 8)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Yuri’s picture

Yes, I think that showing the 'current value' should be an option, not the default way to show it. The current value is visible in the edit field anyway.

vimalramaka’s picture

I agree. For now, I'm using -

.views-row-edit-static {
display:none;
}

in my theme, but I don't really wanna do that. Please give an option. Thanks.

btopro’s picture

+1

pixelsweatshop’s picture

btopro please use the follow button located in the top-right corner of every thread to subscribe to issues rather than commenting please.

hanoii’s picture

Status: Active » Needs review
FileSize
2.16 KB

Attached is a patch that tries to sort this.

I am unsure if the approach I am taking will work for every single field, but so far my few tests went fine. Probably @joachim can shed some light on that.

joachim’s picture

Status: Needs review » Needs work

Looks ok, though I prefer to avoid settings or variables that are negatives, as then you have to mentally parse a double negative when making sense of a FALSE value.

hanoii’s picture

@joachim not sure I followed? You mean to have a setting to rather show the value than to suppress it? I just followed the same approach as the other hide settings in the module.

btopro’s picture

@hanoii I agree; it's following the convention provided by the description suppression field setting listed just above it. Behavior makes sense to me.

hollyfox’s picture

Is there anything going on with this issue? I have a view from my D6 site that uses Editable Views that did not have the current value; only the edit box. I need to see if I can get this to work.

Sata’s picture

I've applied patch #5, I don't see any issues thus far. Exactly what I was looking for. I change the default suppress value to TRUE as it seems redundant so I want the exception to be FALSE.

rooby’s picture

Issue summary: View changes

I have also tried the patch and it provides the expected functionality and doesn't seem to cause any problems.

jojonaloha’s picture

Status: Needs work » Needs review
FileSize
3.75 KB
1.02 KB

The attached patch is mostly a re-roll of #5. It also adds this option to the Title edit field.

I also don't see an issue double negative since it is consistent with the other options.

Status: Needs review » Needs work

The last submitted patch, 12: editableviews-option_to_hide_current-1980238-12.patch, failed testing.

BrightBold’s picture

I'd love to see this patch get in. The 18 exceptions are all Undefined index: suppress_value. Seems like that's probably a simple fix (I know in a template that error means you're missing an if (isset (...) but I'm not enough of a module developer to figure out what's needed.

dqd’s picture

re-queued for testing ...

The last submitted patch, 12: editableviews-option_to_hide_current-1980238-12.patch, failed testing.

The last submitted patch, 5: 1980238-5-option-supress-value.patch, failed testing.

robertwb’s picture

Status: Needs work » Needs review
FileSize
3.4 KB

Attached patch updates #12 to test to see if "suppress_value" exists on handler options array, and if not, outputs the value (equivalent to suppress_value === FALSE). If the options array does contain this key, it handles it.

MrPeanut’s picture

Patch from #20 applies and works great!

lunk rat’s picture

@hanoii thank you for #5; @robertwb thank you for #20. I am using #20, it applied cleanly, it works great, and I think it is needed for many use-cases because it is a powerful way to reduce clutter on a large editable view.

lunk rat’s picture

Status: Needs review » Reviewed & tested by the community

Setting RTBC.

joachim’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/handlers/editableviews_handler_field_field_edit.inc
@@ -62,6 +63,13 @@ class editableviews_handler_field_field_edit extends views_handler_field_field {
+      '#description' => t('If selected, the value on field is hidden.'),

This needs a reword. Other than that, looks good. Thanks for the reviews!

Zekvyrin’s picture

patch works great for me as well

Zekvyrin’s picture

Updated checkbox's description (as mentioned in #24) to help commit it sooner..

Zekvyrin’s picture

Status: Needs work » Needs review
Zekvyrin’s picture

Sorry.. ignore my previous one.. (I forgot to change the description in the 2nd case)

g33kg1rl’s picture

This patch works for me. :)

Anas_maw’s picture

Status: Needs review » Reviewed & tested by the community

Great Patch please commit it.

P2790’s picture

Yes patch works great, please commit

wOOge’s picture

Confirmed, patch from #28 applies and functionality works as expected.

g33kg1rl’s picture

bump

DuneBL’s picture

#28 is rocks!

adigunsherif’s picture

hurray! 28 works