Field Formatter Gallery Compact missing " [#1980380]

I configured an unlimited image filed the formatter as follows: Show gallery on field in compact mode.
In the frontend I found out that the first image was shown but the rest wasn't. I did some digging and found this line in theme_shadowbox_formatter

 return '<div class="' . $wrapper_classes . '"' . (( $variables['itemid'] == 0 || (isset($variables['compact']) && !$variables['compact']) ) ? '' : 'style="display:none;' ) . '>' . $output . '</div>';

Note the missing " behind display:none;

Comment	File	Size	Author
#5	1980308-fix-Field-Formatter-Gallery-Compact-missing.patch	725 bytes	Bathie
#3	1980308-fix-Field-Formatter-Gallery-Compact-missing.patch	725 bytes	Bathie

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Honestly Illustrated CreditAttribution: Honestly Illustrated commented 29 May 2013 at 11:15

Priority:

Critical

» Normal

Confirmed: Line 558

Comment #2

plusproduit CreditAttribution: plusproduit commented 28 November 2013 at 17:15

Thanks

Comment #3

Bathie CreditAttribution: Bathie commented 11 December 2013 at 15:27

Issue summary:

View changes

File	Size
1980308-fix-Field-Formatter-Gallery-Compact-missing.patch	725 bytes

Add a patch to fix Field Formatter Gallery Compact missing.

Comment #4

Selfirian CreditAttribution: Selfirian commented 12 December 2013 at 05:14

Hi, this didn't work for me I had to change the patch a bit in order to have it working, it's a small css thing but it's the first time I find an error I actually could fix myself :) The " comes after none;

diff --git a/shadowbox.module b/shadowbox.module
index 9531a81..6654e8f 100644
--- a/shadowbox.module
+++ b/shadowbox.module
@@ -555,5 +555,5 @@ function theme_shadowbox_formatter($variables) {
 
   $wrapper_classes = ($gallery_id != '') ? "sb-image sb-gallery sb-gallery-$gallery_id" : 'sb-image sb-individual';
 
-  return '<div class="' . $wrapper_classes . '"' . (( $variables['itemid'] == 0 || (isset($variables['compact']) && !$variables['compact']) ) ? '' : 'style="display:none;' ) . '>' . $output . '</div>';
+ return '<div class="' . $wrapper_classes . '"' . (( $variables['itemid'] == 0 || (isset($variables['compact']) && !$variables['compact']) ) ? '' : 'style="display:none;"' ) . '>' . $output . '</div>';
 }