This is a follow-up to #1807042: Reorganizie entity storage/list/form/render controller annotation keys.

The exceptions that are thrown by the entity manager can now be quite confusion to people who've never seen them before, as a missing storage controller exception reads "The entity (...) did not specify a storage" (the word "controller" is no longer there).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, drupal_1807042_60.patch, failed testing.

tstoeckler’s picture

RTBC if it applies.

Xano’s picture

Status: Needs work » Needs review
FileSize
1.65 KB
Xano’s picture

FileSize
1.88 KB

I made the messages more consistent, and added a 'top-level' exception that is thrown if the entire entity type is unknown to prevent WTFs.

amateescu’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 12eba56 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.