Problem/Motivation

In some instances, the file entry in the $variables passed to template_preprocess_jw_player() is an object. But the code assume it will always be an array. This happen when using JW Player as file formatter with File Entity.

Proposed resolution

Cast $variables['file'] as array at the beginning of template_preprocess_jw_player().

Original report by @username

Fatal error: Cannot use object of type stdClass as array in /drupal/sites/all/modules/contrib/jw_player/jw_player.module on line 382

$variables['file'] is an object. Patch below.

CommentFileSizeAuthor
#5 jw_player-cant_user_object_as_array-1980940-5.patch873 bytespbuyle
#4 jw_player-cant_use_object_as_array-1980940-4.patch512 bytesjethro
#1 jw_player-cant_use_object_as_array-1980940-1.patch410 bytesrrrob
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rrrob’s picture

rrrob CreditAttribution: rrrob commented
FileSize
jw_player-cant_use_object_as_array-1980940-1.patch410 bytes
deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented

Patch gave me opposite error:

Notice: Trying to get property of non-object in template_preprocess_jw_player() (line 382 of /public_html/d7/sites/all/modules/jw_player/jw_player.module).

It was working just fine before the patch.

hermes_costell’s picture

hermes_costell CreditAttribution: hermes_costell commented 
if(is_object($variables['file'])){
			$variables['config']['file'] = file_create_url($variables['file']->uri);
		}else{
			$variables['config']['file'] = file_create_url($variables['file']['uri']);
		}

going to need something like this also at line 350 for

$id = $variables['file']['fid'] . $variables['preset'];

jethro’s picture

jethro CreditAttribution: jethro commented
Status: Active » Needs review
FileSize
jw_player-cant_use_object_as_array-1980940-4.patch512 bytes

This works for me:

if(is_object($variables['file'])) {
$variables['file'] = (array) $variables['file'];
}

pbuyle’s picture

pbuyle CreditAttribution: pbuyle commented
Title: Cannot use object of type stdClass as array » Cannot use object of type stdClass as array in template_preprocess_jw_player()
Issue summary: View changes
FileSize
jw_player-cant_user_object_as_array-1980940-5.patch873 bytes

This happen to me when using JW Player as file formatter with File Entity.
Patch in #4 does not apply anymore. The attached patch is a reroll.

  • mongolito404 committed 3658a94 on 7.x-2.x 
    Issue #1980940: Cannot use object of type stdClass as array in...
pbuyle’s picture

pbuyle CreditAttribution: pbuyle commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.