Problem/Motivation

Part of #1921610: [Meta] Architect our CSS
The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868

It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.

The Forum module does not yet follow the guidelines.

Proposed resolution

forum.css into css/forum.skin.css
forum-rtl.css into css/forum.skin-rtl.css

In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.

This is part of the CSS standard described at http://drupal.org/node/1887922

Remaining tasks

Test if with this patch the CSS is being added to Drupal from its new location with its new name

User interface changes

none

API changes

The forum.module's CSS files will have new names.

By akmalfikri and Gomez_in_the_South

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akmalfikri’s picture

Status: Active » Needs review
FileSize
3.88 KB

Here's the patch

akmalfikri’s picture

Gomez_in_the_South’s picture

Status: Needs review » Active

I reviewed the patch from #2 and the CSS is being added to Drupal from its new location with its new name. It is RTBC from me, but I'll let the testbot review first. :-)

echoz’s picture

Title: Rename book module CSS files to match new file naming convention » Rename forum module CSS files to match new file naming convention
Status: Active » Needs review
akmalfikri’s picture

Ignore #1

akmalfikri’s picture

Issue tags: +Novice, +mobile, +d8mux, +d8mux-css-cleanup

Adding tags

Gomez_in_the_South’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed and tested.

Shyamala’s picture

tagging

Shyamala’s picture

Status: Reviewed & tested by the community » Needs review

Thanks @gomez_in_the_south! Can you confirm what you reviewed, refer: http://drupal.org/node/1489010.
Please read http://drupal.org/node/1489010 for details on Manual testing.

Shyamala’s picture

@Gomez_in_the_South thanks for the testing!
Can you confirm what you reviewed, refer: http://drupal.org/node/1489010.
Please read http://drupal.org/node/1489010 for details on Manual testing.
check john's review at http://drupal.org/node/1981026#comment-7352628

Changing status to needs review

dcam’s picture

Status: Needs review » Needs work
FileSize
2.96 KB

#2 needs work. The forum-icons.png URL needs to be updated.

+++ b/core/modules/forum/css/forum.module.cssundefined
@@ -0,0 +1,47 @@
+#forum .icon{
+  background-image: url(../../misc/forum-icons.png);
+  background-repeat: no-repeat;
+  float: left; /* LTR */
+  height: 24px;
+  margin: 0 9px 0 0; /* LTR */
+  width: 24px;
+}

Otherwise, the patch looks good. I didn't find any additional uses of the old CSS file names. The moved CSS files in the /css directory are being applied to the forum pages.

after.png

akmalfikri’s picture

Status: Needs work » Needs review
FileSize
3.89 KB

My bad. Here's the latest patch.

aspilicious’s picture

+++ b/core/modules/forum/css/forum.module-rtl.cssundefined
@@ -0,0 +1,24 @@
+.forum-topic-navigation .topic-previous {
+  text-align: left;
+  float: right;
+}
+.forum-topic-navigation .topic-next {
+  text-align: right;
+  float: left;

I believe the standard is ti put all the cs sin alphabetical order (except for some exceptions for vender prefixes). Can we do that here?

aspilicious’s picture

Apparantly that rule is gone in the new standards :). So forget my comment.

http://drupal.org/node/1887862#declaration-order

akmalfikri’s picture

FileSize
1.27 KB

Hi guys,

Apparently my git does not comply with the git config stated here : http://drupal.org/documentation/git/configure

After applied the new git config, here is the rerolled patch. I hope it's the correct one.

Status: Needs review » Needs work
Issue tags: -Novice, -mobile, -d8mux, -d8mux-css-cleanup

The last submitted patch, 1981036-forum-css.patch, failed testing.

akmalfikri’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +mobile, +d8mux, +d8mux-css-cleanup

#15: 1981036-forum-css.patch queued for re-testing.

dcam’s picture

Status: Needs review » Reviewed & tested by the community

#15 looks good. It incorporates the change from #11 and fixes the file renaming issue.

Shyamala’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

Created a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.

Refer: http://drupal.org/node/1921610#comment-7375894

JohnAlbin’s picture

Project: Drupal core » Drupal 8 Mobile Initiative
Version: 8.x-dev »
Component: CSS » CSS architecture
Status: Closed (duplicate) » Reviewed & tested by the community

Sorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.

Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)

So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)

mtift’s picture

Status: Reviewed & tested by the community » Fixed

Committed to the sandbox! :-)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Added steps for testing