Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
#1921610: [Meta] Architect our CSS
The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868
It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.
The field module does not yet follow these guidelines.
Proposed resolution
field.css becomes field.module.css
field-rtl.css becomes field.module-rtl.css
In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.
This is part of the CSS standard described at http://drupal.org/node/1887922
Remaining tasks
Test if with this patch the CSS is being added to Drupal from its new location with its new name
User interface changes
none
API changes
The system.module's CSS files will have new names.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1981038-field-css-1-fixed.patch | 1.38 KB | Kevin Morse |
| #5 | 1981038-field-css-1-fixed.patch | 1.38 KB | Kevin Morse |
| #3 | after.png | 2.94 KB | dcam |
| #1 | 1981038-field-css-1.patch | 3.37 KB | criticny |
Comments
Comment #1
criticny CreditAttribution: criticny commentedMoved field.css and field-rtl.css per suggested new css naming convention.
Comment #1.0
criticny CreditAttribution: criticny commentedupdated the exact names of the files changed
Comment #2
Shyamala CreditAttribution: Shyamala commentedTagging
Comment #3
dcam CreditAttribution: dcam commented#1 is RTBC. I didn't find any additional uses of the old stylesheet file names. The moved stylesheet in the /css directory is being applied to all pages.
Comment #4
tim.plunkettThis needs to be rerolled with proper git configuration: http://drupal.org/documentation/git/configure
Comment #5
Kevin Morse CreditAttribution: Kevin Morse commentedI think the rename instead of delete and add are what you mean?
This should do it.
Comment #6
Kevin Morse CreditAttribution: Kevin Morse commentedBlah forgot to change status.
Comment #7
Kevin Morse CreditAttribution: Kevin Morse commentedSorry. This should really do it.
Comment #8
Shyamala CreditAttribution: Shyamala commentedCreated a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.
Refer: http://drupal.org/node/1921610#comment-7375894
Comment #9
JohnAlbinSorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.
Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)
So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)
Comment #10
mtiftThis one looks good to me.
Comment #11
JohnAlbinCommitted to the sandbox! thanks!
Comment #12.0
(not verified) CreditAttribution: commentedAdded steps for testing