Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Part of #1921610: [Meta] Architect our CSS
Problem/Motivation
The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868
It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.
The node module does not yet follow these guidelines.
Proposed resolution
node.admin.css => css/node.admin.css
node.edit.admin.css => css/node.module.css.
In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.
This is part of the CSS standard described at http://drupal.org/node/1887922
Remaining tasks
Test if with this patch the CSS is being added to Drupal from its new location with its new name
User interface changes
none
API changes
The node.module's CSS files will have new names.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1981050-node-css-7.patch | 3.79 KB | nick_schuch |
| #4 | 1981050-node-css-4.patch | 8.18 KB | kim.pepper |
| #4 | interdiff.txt | 1.06 KB | kim.pepper |
| #1 | 1981050-node-css-1.patch | 7.12 KB | kim.pepper |
Comments
Comment #1
kim.pepperMoved css files as per summary above.
Comment #2
Shyamala CreditAttribution: Shyamala commentedTagging
Comment #2.0
Shyamala CreditAttribution: Shyamala commentedUpdated summary
Comment #3
izus CreditAttribution: izus commentedHi,
I tested the patch locally and Firebug was crying because it can't load node.edit.admin.css which is deleted. Actually we still hae two references to that file : one in seven_form_node_form_alter and the other in styles.css
Comment #4
kim.pepperThanks for find that. Fixed.
Comment #5
izus CreditAttribution: izus commentedHi,
Looks good for me
Thanks
Comment #6
tim.plunkettThis needs to be rerolled with proper git configuration: http://drupal.org/documentation/git/configure
Comment #7
nick_schuch CreditAttribution: nick_schuch commentedRerolled as per #6
Comment #8
izus CreditAttribution: izus commented#4 seems to do more than what #7 is doing (8.18 KB vs 3.79 KB)
Comment #9
kim.pepper@izus I think it's just the diff of copied files @tim.plunkett was referring to in #6. See Optimize "diffs for renamed and copied files".
Comment #10
izus CreditAttribution: izus commentedOh true @kim.pepper, Thanks
I reviwed it again , it seems good
Comment #11
Shyamala CreditAttribution: Shyamala commentedCreated a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.
Refer: http://drupal.org/node/1921610#comment-7375894
Comment #12
JohnAlbinSorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.
Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)
So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)
Comment #13
mtiftCommitted to the sandbox! :-)
Comment #14.0
(not verified) CreditAttribution: commentedsteps for testing