Problem/Motivation
The BAT (base-admin-theme) file organization we started to do in Drupal 8 was a fantastic idea. See http://drupal.org/node/1089868
It works really well, but its names conflict with the SMACSS categorization we're using in Drupal 8. "base" and "theme" means something else in SMACSS. So we just need to rename them.
This is applied to the simpletest module.
Proposed resolution
MODULE.base.css becomes MODULE.module.css.
MODULE.admin.css stays the same (but requires adding a MODULE.admin.skin.css so admin themes can override the default skin).
And MODULE.theme.css becomes MODULE.skin.css.
In addition, since our template files are now in a templates
sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.
This is part of the CSS standard described at http://drupal.org/node/1887922
Remaining tasks
This issue is blocked by #1924436: Remove separate CSS_AGGREGATE_SYSTEM aggregate file and fix drupal_add_library() to aggregate CSS properly
After this issue's completion, we still have all the other steps outlined at #1921610: [Meta] Architect our CSS.
User interface changes
none
API changes
The simpletest.module's CSS files will have new names.
Comment | File | Size | Author |
---|---|---|---|
#14 | rename-simpletest-css-file-1981072-14.patch | 3.42 KB | dealancer |
#12 | after.png | 3.21 KB | dcam |
#11 | rename-simpletest-css-file-1981072-11.patch | 7.36 KB | dealancer |
#8 | rename-simpletest-css-file-1981072-8.patch | 5.56 KB | dealancer |
#5 | rename-simpletest-css-file-1981072-5.patch | 5.57 KB | dealancer |
Comments
Comment #1
svenryen CreditAttribution: svenryen commentedPatch
Comment #2
svenryen CreditAttribution: svenryen commentedComment #4
Shyamala CreditAttribution: Shyamala commentedTagging
Comment #5
dealancer CreditAttribution: dealancer commentedFixed typo.
Comment #6
dealancer CreditAttribution: dealancer commentedComment #8
dealancer CreditAttribution: dealancer commentedThe problem was in drupal_add_css array. Looks like keys contains filename without path to it. Updated test.
Comment #9
dealancer CreditAttribution: dealancer commentedComment #10
andypostno new file attached!!!
Comment #11
dealancer CreditAttribution: dealancer commentedWhoops... Re-rolled.
Comment #12
dcam CreditAttribution: dcam commented#11 is RTBC. I didn't find any additional usages of simpletest.css. The moved stylesheet is being applied correctly to the testing table, batch, and results pages.
Comment #13
tim.plunkettThis needs to be rerolled with proper git configuration: http://drupal.org/documentation/git/configure
Comment #14
dealancer CreditAttribution: dealancer commentedDone!
Comment #15
Shyamala CreditAttribution: Shyamala commentedCreated a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.
Refer: http://drupal.org/node/1921610#comment-7375894
Comment #16
JohnAlbinSorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.
Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)
So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)
Comment #17
mtiftThis one looks good to me
Comment #18
JohnAlbinCommitted to the sandbox! :-)