This is part of #1921610: [Meta] Architect our CSS
Problem/Motivation
The taxonomy module does not follow the guidelines in [#1887918]
Proposed resolution
taxonomy.css becomes taxonomy.module.css
In addition, since our template files are now in a templates
sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.
This is part of the CSS standard described at http://drupal.org/node/1887922
Remaining tasks
Needs manual testing - Test with this patch the CSS is being added to Drupal from its new location with its new name
User interface changes
none
API changes
The taxonomy.module's CSS files will have new names.
Comment | File | Size | Author |
---|---|---|---|
#11 | 1981080-taxonomy-css-11.patch | 2.22 KB | mtift |
#6 | after.PNG | 3.08 KB | dcam |
#5 | 1981080-taxonomy-css-5.patch | 2.13 KB | nick_schuch |
#1 | 1981080-taxonomy-css-1.patch | 2.81 KB | kim.pepper |
Comments
Comment #1
kim.pepperMakes changes as per summary.
Comment #1.0
kim.pepperFixed copy paste error
Comment #1.1
kim.pepperFixed incorrect node id
Comment #2
Shyamala CreditAttribution: Shyamala commentedtagging
Comment #3
izus CreditAttribution: izus commentedHi,
The patch lokks good.
it applys well and the new name is loaded
Thanks
Comment #4
tim.plunkettThis needs to be rerolled with proper git configuration: http://drupal.org/documentation/git/configure
Comment #5
nick_schuch CreditAttribution: nick_schuch commentedRerolled as per #4
Comment #6
dcam CreditAttribution: dcam commented#5 is RTBC. It was rerolled so that the files are renamed instead of deleted/added, per #4. I found no instances of the old file name remaining in the code. The stylesheet is being added to pages with its new path.
Comment #7
dcam CreditAttribution: dcam commentedComment #8
Shyamala CreditAttribution: Shyamala commentedCreated a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.
Refer: http://drupal.org/node/1921610#comment-7375894
Comment #9
JohnAlbinSorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.
Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)
So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)
Comment #10
mtiftI'll re-roll this one
Comment #11
mtiftHere's a re-roll
Comment #12
dcam CreditAttribution: dcam commented#11 is RTBC. It's the same basic patch from #5 I RTBC'ed in #6, rerolled.
Comment #13
JohnAlbinCommitted to the sandbox! Thanks!
Comment #14.0
(not verified) CreditAttribution: commentedAdded steps for testing