This is part of #1921610: [Meta] Architect our CSS

Problem/Motivation

The taxonomy module does not follow the guidelines in [#1887918]

Proposed resolution

taxonomy.css becomes taxonomy.module.css

In addition, since our template files are now in a templates sub-directory of a module, we should do the same for the CSS. Note that the toolbar, tour and views modules already do that.

This is part of the CSS standard described at http://drupal.org/node/1887922

Remaining tasks

Needs manual testing - Test with this patch the CSS is being added to Drupal from its new location with its new name

User interface changes

none

API changes

The taxonomy.module's CSS files will have new names.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper’s picture

Status: Active » Needs review
Issue tags: +Needs manual testing
FileSize
2.81 KB

Makes changes as per summary.

kim.pepper’s picture

Project: Drupal core » Drupal 8 Mobile Initiative
Issue summary: View changes

Fixed copy paste error

kim.pepper’s picture

Issue summary: View changes

Fixed incorrect node id

Shyamala’s picture

Project: Drupal 8 Mobile Initiative » Drupal core
Issue tags: +Novice, +mobile, +d8mux, +d8mux-css-cleanup

tagging

izus’s picture

Status: Needs review » Reviewed & tested by the community

Hi,
The patch lokks good.
it applys well and the new name is loaded
Thanks

tim.plunkett’s picture

Status: Reviewed & tested by the community » Needs work

This needs to be rerolled with proper git configuration: http://drupal.org/documentation/git/configure

nick_schuch’s picture

Status: Needs work » Needs review
FileSize
2.13 KB

Rerolled as per #4

dcam’s picture

FileSize
3.08 KB

#5 is RTBC. It was rerolled so that the files are renamed instead of deleted/added, per #4. I found no instances of the old file name remaining in the code. The stylesheet is being added to pages with its new path.

dcam’s picture

Status: Needs review » Reviewed & tested by the community
Shyamala’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

Created a single issue to rename all css files at: #1987066: Rename files to match CSS file naming convention based on request by webchick to make review easier. Thanks everyone on this issue, looking to your continued participation in the new issue.

Refer: http://drupal.org/node/1921610#comment-7375894

JohnAlbin’s picture

Project: Drupal core » Drupal 8 Mobile Initiative
Version: 8.x-dev »
Component: CSS » CSS architecture
Status: Closed (duplicate) » Reviewed & tested by the community

Sorry for the delay in reviewing these patches. My bronchitis flared up and I've been too sick until this week to get back into the issue queue.

Lots of discussions have happened in the interim. We just held a D8 Mobile Initiative meeting on Google+: https://plus.google.com/u/1/events/c0knva4lgh4vot0nun5lbfel9fc where we decided that we could make the CSS re-archicture work move faster by moving the work into a sandbox git repository. Then we could commit lots of little issues to the sandbox and roll larger, more-complete patches into Drupal 8’s issue queue. (per webchick's request)

So you're work is not lost! I'm moving this issue to the Mobile Initiative sandbox. :-)

mtift’s picture

Assigned: kim.pepper » mtift
Status: Reviewed & tested by the community » Needs work

I'll re-roll this one

mtift’s picture

Status: Needs work » Needs review
FileSize
2.22 KB

Here's a re-roll

dcam’s picture

Status: Needs review » Reviewed & tested by the community

#11 is RTBC. It's the same basic patch from #5 I RTBC'ed in #6, rerolled.

JohnAlbin’s picture

Status: Reviewed & tested by the community » Fixed

Committed to the sandbox! Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Added steps for testing