It is no longer used..well since drupal 7 actually
It is used in drupal 6 in decode_entities but in 7 we switched to html_entity_decode

CommentFileSizeAuthor
#1 drupal-remove_unicode_entities-1981190-1.patch5.82 KBParisLiakos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Needs review
FileSize
drupal-remove_unicode_entities-1981190-1.patch5.82 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Tagging :)

Status: Needs review » Needs work

The last submitted patch, drupal-remove_unicode_entities-1981190-1.patch, failed testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs work » Needs review

#1: drupal-remove_unicode_entities-1981190-1.patch queued for re-testing.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

I grepped through and couldn't find any use of $html_entities.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue tags: +Needs backport to D7, +D8MI

Oh, nice.

Tagging D8MI just to let those folks chime in here and confirm/deny.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs review

Committed 105ce44 and pushed to 8.x. Thanks!

I think the patch will apply to D7...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Committed 105ce44 and pushed to 8.x. Thanks!

I think the patch will apply to D7...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue tags: -Needs backport to D7, -D8MI

#1: drupal-remove_unicode_entities-1981190-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs backport to D7, +D8MI

The last submitted patch, drupal-remove_unicode_entities-1981190-1.patch, failed testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

d7 has no core/ yet:P

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Patch (to be ported)

doh :) updating status then

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented

Hm, it looks like the patch in #878408: Replace decode_entities() with built-in html_entity_decode() removed it but the file was never deleted when the patch was committed...

At this point, is it really worth removing from Drupal 7? It's not causing any harm in the filesystem, and you never know if someone out there is using it for some reason.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 7.x-dev » 8.x-dev
Status: Patch (to be ported) » Fixed
Issue tags: -Needs backport to D7

Agree with #13... it's just not worth it. And you never know... :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Add more info