Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#23 | interdiff.txt | 1.22 KB | pcambra |
#23 | 1981314-23.patch | 112.04 KB | pcambra |
#17 | interdiff.txt | 7.83 KB | pcambra |
#17 | 1981314-17.patch | 112 KB | pcambra |
#16 | interdiff.txt | 49.86 KB | pcambra |
Comments
Comment #1
andypostalso fixed doc-block comment
Comment #2
andyposttagged to office hours
Comment #3
swentel CreditAttribution: swentel commentedWe're going todo this in one patch.
Comment #4
swentel CreditAttribution: swentel commentedSo we agreed to this in chunks anyway.
Comment #5
swentel CreditAttribution: swentel commented#1: 1953410-cud-1981314-1.patch queued for re-testing.
Comment #7
swentel CreditAttribution: swentel commentedrerolled - not sure if the diff was taken right as it's so big, but I assume it's ok.
Comment #9
aspilicious CreditAttribution: aspilicious commentedYou removed to much ;)
Hopefully this one will apply and come back green
Comment #10
aspilicious CreditAttribution: aspilicious commentedHere is the patch. I don't think we should clean this one up as the others. Will be an unneeded bikeshed issue.
I hope for less than 5 fails :p
Comment #12
aspilicious CreditAttribution: aspilicious commentedANother try
Comment #14
aspilicious CreditAttribution: aspilicious commented#12: 1981314-12.patch queued for re-testing.
Comment #15
pcambraWorking on this, I'll post a patch in a few mins.
Comment #16
pcambra#12 is a patch from another issue :(
Rerrolling #10 and fixing a number of docs, scopes and typos.
Also, are we keeping the field crud functions in field.crud.inc for compatibility purposes or shall we delete those as well?
Comment #17
pcambraAfter discussing with swentel on IRC, we're removing the field crud functions in this patch.
Expect this one to fail horribly, as all the dependent ones are going to still call the crud functions.
Comment #19
pcambra#17: 1981314-17.patch queued for re-testing.
Comment #20
andypostLet's finish it!
Comment #21
aspilicious CreditAttribution: aspilicious commented#17: 1981314-17.patch queued for re-testing.
Comment #22
effulgentsia CreditAttribution: effulgentsia commentedsave() does not return the entity. It actually returns a constant. How is it this isn't triggering test errors?
Comment #23
pcambraBecause apparently $this->instances is not invoked from anywhere.
Re-roll removing the instances array as it's unused.
Comment #24
andypostReviewed again and I see no nitpicks
Comment #25
Dries CreditAttribution: Dries commentedWoot! Committed to 8.x. Thanks.