Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#30 | 1981334-30.patch | 31.75 KB | pcambra |
#27 | 1981334-27.patch | 31.59 KB | pcambra |
#21 | 1981334-21.patch | 31.73 KB | swentel |
#21 | interdiff.txt | 657 bytes | swentel |
#20 | interdiff.txt | 3.52 KB | pcambra |
Comments
Comment #1
andypostComment #2
andyposttaggin
Comment #3
andyposttagged to office hours
Comment #4
swentel CreditAttribution: swentel commentedWe're going todo this in one patch.
Comment #5
swentel CreditAttribution: swentel commentedSo we agreed to this in chunks anyway.
Comment #6
swentel CreditAttribution: swentel commented#1: 1953410-cud-1981334-1.patch queued for re-testing.
Comment #8
swentel CreditAttribution: swentel commentedrerolled
Comment #10
swentel CreditAttribution: swentel commented#8: 1981334-8.patch queued for re-testing.
Comment #12
aspilicious CreditAttribution: aspilicious commentedLets see if I made typos...
Comment #14
pcambraHere we go
Comment #15
pcambraComment #16
aspilicious CreditAttribution: aspilicious commentedRerolled and tried to fix typos
Comment #18
aspilicious CreditAttribution: aspilicious commented:)
Comment #19
aspilicious CreditAttribution: aspilicious commentedI'll leave this one for pcambra
Comment #20
pcambraNot sure what the typos were fixed by @aspilicious, we really could use interdiffs here :)
Fixed a couple of things regarding node access tests.
Comment #21
swentel CreditAttribution: swentel commentedwonderful again, thanks!
One nitpick in the docs.
Comment #22
alexpott#21: 1981334-21.patch queued for re-testing.
Comment #24
andypost#21: 1981334-21.patch queued for re-testing.
Comment #25
andypostback to rtbc
Comment #26
alexpottNeeds a reroll...
Comment #27
pcambraCatching up with HEAD.
Comment #28
swentel CreditAttribution: swentel commentedshould be interface no ?
You can mark it RTBC when you re-roll
Comment #29
andypostYes, this needs to be a interface
Comment #30
pcambraHere we go, changed to UserInterface
Comment #31
pcambraComment #32
andypostMaybe we should convert this to FieldDefinitionInterface?
See #1950632: Create a FieldDefinitionInterface and use it for formatters and widgets
Comment #33
pcambraI've created #2022207: User test vars declared as \Drupal\user\Plugin\Core\Entity\User where it should be \Drupal\user\UserInterface for the UserInterface docs cleanup, maybe that one should be a followup too?
Comment #34
andypostMakes sense! docs could be cleaned after july 1
Comment #35
alexpottCommitted a4bfb01 and pushed to 8.x. Thanks!