Markup for: overlay module [#1982270]

Meta issue: #1980004: [meta] Creating Dream Markup
Issue based on: #1898436: overlay.module - Convert PHPTemplate templates to Twig

Questions:

Can we please remove all the Id's?
Please? :)

Markup proposal:

<div id="overlay"{{ attributes }}>
  <div class="overlay-titlebar clearfix">
    <div class="overlay-title-wrapper clearfix">
      <h3 class="overlay-title"{{ title_attributes }}>{{ title }}</h3>
    </div>
      <a class="overlay-close" href="#"><span class="element-invisible">{{ 'Close overlay'|t }}</span></a>
    {% if tabs %}
      <h2 class="element-invisible">{{ 'Primary tabs'|t }}</h2>
      <ul class="overlay-tabs">{{ ender_var(tabs) }}</ul>
    {% endif %}
  </div>
  <div class="overlay-content"{{ content_attributes }}>
    {{ page }}
  </div>
</div>

Comments

Comment #1

oresh CreditAttribution: oresh commented 2 May 2013 at 19:41

Project:		» Drupal core
Version:		» 8.x-dev
Component:	Twig templates conversion (front-end branch)	» markup
Category:	feature	» task

moving to core issues.

Comment #2

mortendk CreditAttribution: mortendk commented 14 May 2013 at 22:27

<div id="overlay"{{ attributes }}>
  <div class="overlay-titlebar">
     <h3{{ title_attributes }}>{{ title }}</h3>
      <a class="overlay-close" href="#"><span class="element-invisible">{{ 'Close overlay'|t }}</span></a>
    {% if tabs %}
      <h2 class="element-invisible">{{ 'Primary tabs'|t }}</h2>
      <ul class="overlay-tabs">{{ ender_var(tabs) }}</ul>
    {% endif %}
  </div>
  <div class="overlay-content"{{ content_attributes }}>
    {{ page }}
  </div>
</div>

clearfix must die ;)