We need paypal wps refund functionality similar to the one implemented on commerce_be2bill. We would also need it to have the partial refund functionality.

CommentFileSizeAuthor
#16 allow_paypal_wps-1982294-16.patch43.06 KBjsuchogorskafp
#16 interdiff_15_16.patch2.14 KBjsuchogorskafp
#15 allow_paypal_wps-1982294-15.patch43.26 KBfpalewacki
#15 allow_paypal_wps-1982294-15.patch43.26 KBfpalewacki
#15 interdiff_14_15.patch2.59 KBfpalewacki
#14 interdiff_13-14.patch1.06 KBRonino
#14 allow_paypal_wps-1982294-14.patch43.04 KBRonino
#13 allow_paypal_wps-1982294-13.patch42.75 KBlathan
#12 allow_paypal_wps-1982294-12.patch42.73 KBlathan
#9 allow_paypal_wps-1982294-9.patch43.7 KBYurkinPark
#8 allow_paypal_wps-1982294-8.patch43.67 KBYurkinPark
#7 commerce_paypal-paypal_refund-1982294-7.patch40.64 KBvasike
#6 commerce_paypal-paypal_refund-1982294-6.patch32.13 KBvasike
#5 commerce_paypal-paypal_refund-1982294-5.patch30.97 KBvasike
#3 commerce_paypal-paypal_refund-1982294-3.patch21.86 KBvasike
#1 commerce_paypal-paypal_refund-1982294.patch21.79 KBolteanu5000
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

olteanu5000’s picture

olteanu5000 CreditAttribution: olteanu5000 commented
FileSize
commerce_paypal-paypal_refund-1982294.patch21.79 KB

Attached patch with desired functionality. Inspired by paypal wpp module and commerce_be2bill module.

olteanu5000’s picture

olteanu5000 CreditAttribution: olteanu5000 commented
Status: Active » Needs review
vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Title: Allow Paypal WPS refund from admin order management page » Allow Paypal WPS Capture and Refund from admin order management page
Version: 7.x-1.0-rc1 » 7.x-2.x-dev
Issue summary: View changes
FileSize
commerce_paypal-paypal_refund-1982294-3.patch21.86 KB

Let's move this one to the current (2.x) version of the module.
patch re-rolled.

Also re-titled, the patch includes also the Capture option for Authorized payments.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs review » Needs work

it seems it needs more work.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Title: Allow Paypal WPS Capture and Refund from admin order management page » Allow Paypal WPS Capture, Void and Refund from admin order management page
Status: Needs work » Needs review
FileSize
commerce_paypal-paypal_refund-1982294-5.patch30.97 KB

There is a new patch for this - it is a re-work of the previous one.
I added also the Void option to the Pending payments.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
FileSize
commerce_paypal-paypal_refund-1982294-6.patch32.13 KB

it seems there some more work needed for Refund, some changes to WPS IPN process for refunds.
there is an updated patch for this.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
FileSize
commerce_paypal-paypal_refund-1982294-7.patch40.64 KB

there is a new patch that completes the solution for this with Rules integration:
Rules Actions available for Capture/Refund/Void.
This means it could also used with VBOs (Rules components).

YurkinPark’s picture

YurkinPark CreditAttribution: YurkinPark at Skilld commented
Version: 7.x-2.x-dev » 7.x-2.3
FileSize
allow_paypal_wps-1982294-8.patch43.67 KB

Thanks for the patch. As i discovered, this patch can be implemented for 7.x-2.3 as well.
I found one issue after implementing this patch. Sometimes, PayPal doesn't authorize payment, and returns

[payment_status] => Pending
...
[pending_reason] => paymentreview

instead of 

[payment_status] => Pending
...
[pending_reason] => authorization

This means you have not provide service/ship merchandise. Check in official documentation https://developer.paypal.com/docs/classic/express-checkout/integration-g... . My patch implements previous (7th) patch and provides tools which you can use to cover "payment under review" case.

YurkinPark’s picture

YurkinPark CreditAttribution: YurkinPark at Skilld commented
FileSize
allow_paypal_wps-1982294-9.patch43.7 KB

In case we have many failed transaction before, sometimes i'm obtaining non last transaction (which is paypal transaction). Added condition to match payment method commerce_paypal_wps_check_ipn_pending_reason rule condition callback.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro commented
Version: 7.x-2.3 » 7.x-2.x-dev
Status: Needs review » Needs work

New functionality targets the -dev version, even if the patch applies cleanly on prior point releases. However, it isn't clear to me why you disabled a FALSE return value in the IPN validation function. That seems ... quite drastic to have no explanation. : P

ruvenshilpakar’s picture

ruvenshilpakar CreditAttribution: ruvenshilpakar commented

Hi,
I tried this patch but when i try to complete the checkout and get redirected to the paypal account page, i get an error and nothing happens. What could i be doing wrong? I used the#9 patch

lathan’s picture

lathan
Location Chile
CreditAttribution: lathan at Zilleem commented
Status: Needs work » Needs review
FileSize
allow_paypal_wps-1982294-12.patch42.73 KB

Reroll patch against 7.x-2.x and - added a comment as to why 'disabled a FALSE return value in the IPN validation function'.

lathan’s picture

lathan
Location Chile
CreditAttribution: lathan at Zilleem commented
FileSize
allow_paypal_wps-1982294-13.patch42.75 KB

fix incorrect path in last patch

Ronino’s picture

Ronino CreditAttribution: Ronino as a volunteer commented
FileSize
allow_paypal_wps-1982294-14.patch43.04 KB
interdiff_13-14.patch1.06 KB

I could only test refunds via the sandbox and it mostly works, great! When I do a partial refund first though and then want to refund the remainder, I get these errors:

Refund failed, so the transaction will remain in a pending status.
Can not do a full refund after a partial refund

I enhanced #13 to fix this.

fpalewacki’s picture

fpalewacki CreditAttribution: fpalewacki commented
FileSize
interdiff_14_15.patch2.59 KB
allow_paypal_wps-1982294-15.patch43.26 KB
allow_paypal_wps-1982294-15.patch43.26 KB

Hey, I've fixed a couple of issues and typos and improve multi currency support to get the proper errors returned from PayPal if we created a transaction in a different currency.

Refund request was not sending the currency parameter so if you used different currency in commerce than in PayPal then the transaction would have different currency than the request sent to PayPal resulting in e.g. issuing the "3 EUR" refund but in USD

This ticket is kinda old, I'm on "7.x-2.7" version

jsuchogorskafp’s picture

jsuchogorskafp CreditAttribution: jsuchogorskafp commented
FileSize
interdiff_15_16.patch2.14 KB
allow_paypal_wps-1982294-16.patch43.06 KB

I've fixed issue about order balance, when refund was did from paypal.

Refund from paypal got a confirmation with the e.g "0 EUR", so the order balance does not change.
Refund from platform got confirmation with correct amount and order balance changed.