Comments

Looks like media queries do not change the css selector count.

Status:Active» Fixed
StatusFileSize
new4.59 KB

The following patch has been committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Title:Integrate this moduleLimit CSS selector count to 4095

Status:Closed (fixed)» Needs review
StatusFileSize
new7.84 KB

I have create a patch that allows advagg to part out a single source CSS file over 4095 rules long into multiple parts first, then include them individually as style tags after aggregation.

This patch does assume that there are no media query blocks spanning the rules where it needs to split up the files at. (AKA: around every 4000th rule or about there).

Status:Needs review» Needs work

This patch does assume that there are no media query blocks spanning the rules where it needs to split up the files at. (AKA: around every 4000th rule or about there).

I have a function advagg_parse_media_blocks() that I use for breaking up a CSS file into media query sections. Example usage can be found in this bug that I just fixed #2124391: Off by one error with advagg_parse_media_blocks (was actually working on an example on how to use it for here when I discovered the bug). If you could incorporate the usage of advagg_parse_media_blocks() into your patch so that it will correctly handle large media query blocks that would be helpful :)

Issue summary:View changes

Updated issue summary.

OK I will see if I can implement advagg_parse_media_blocks() in the split line finding part

@branana
Any progress?
:)

Assigned:Unassigned» mikeytown2
Issue summary:View changes

Going to work on this

Status:Needs work» Fixed
StatusFileSize
new12.27 KB

This patch has been committed.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.