Follow up for #1953404: Add config schema to field and instance config entities

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.

Proposed solution

Create a configuration schema for field types, field widget and field storage (if applicable) defined in link module.
Schema in place

Schema not in place
field.link.settings
field.link.instance_settings
field.link.value

field_widget.link_default.settings

Files: 
CommentFileSizeAuthor
#13 1983906-config-schema-link-13.patch992 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,393 pass(es).
[ View ]
#13 1983906-diff-6-13.txt1.35 KBvijaycs85
#13 Screen Shot 2013-12-11 at 19.25.10.png56.65 KBvijaycs85
#13 Screen Shot 2013-12-11 at 19.25.00.png67.24 KBvijaycs85
#11 1983906-provide-config-schema-in-lin-module-11.patch1.25 KBsushantpaste
PASSED: [[SimpleTest]]: [MySQL] 60,292 pass(es).
[ View ]
#6 1983906-provide-config-schema-in-lin-module-6.patch867 bytespiyuesh23
PASSED: [[SimpleTest]]: [MySQL] 56,494 pass(es).
[ View ]
#4 1983906-provide-config-schema-in-lin-module-4.patch893 bytespiyuesh23
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1983906-provide-config-schema-in-lin-module-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 1983906-provide-config-schema-in-lin-module-2.patch1.02 KBaitiba
PASSED: [[SimpleTest]]: [MySQL] 55,559 pass(es).
[ View ]

Comments

Title:Copy of Provide config schema to field types, widgets and storage in link moduleProvide config schema to field types, widgets and storage in link module

Status:Active» Needs review
StatusFileSize
new1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 55,559 pass(es).
[ View ]

After reading all the link provided and taking a look to the similar issue, this is what I have. :-)

Title:Provide config schema to field types, widgets and storage in link moduleProvide config schema to field types and storage in link module
Status:Needs review» Needs work

Widget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.

Status:Needs work» Needs review
StatusFileSize
new893 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1983906-provide-config-schema-in-lin-module-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Moved field_widget out of the schema. Attaching the updated patch.

Status:Needs review» Needs work

The last submitted patch, 1983906-provide-config-schema-in-lin-module-4.patch, failed testing.

StatusFileSize
new867 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,494 pass(es).
[ View ]

Patch rerolled. Attaching a fixed patch.

Status:Needs work» Needs review

With the last commit of the 8.x branch and on this branch I make the "git apply *.patch" and I dont get any errors. I dont know if this information is that is needed to review the issue or I need to be sure that on drupal screens go well too? If I need to be sure of this, ¿how can I make this on this case?

@aitiba The best way to test this would be using config_inspector module(https://drupal.org/project/config_inspector).
For details on how to use it, checkout this link https://drupal.org/node/1910624#comment-7088154.

@piyuesh23 Small modification in patch will be

- # Schema for configuration files of the number module.
+ # Schema for configuration files of the link module.

S.

Issue summary:View changes
StatusFileSize
new1.25 KB
PASSED: [[SimpleTest]]: [MySQL] 60,292 pass(es).
[ View ]

Here is the updated patch.

S.

Status:Needs review» Needs work

This one needs work, sequence needs a '-' when defining the sequence.
And newline needed on the end.

Status:Needs work» Needs review
StatusFileSize
new67.24 KB
new56.65 KB
new1.35 KB
new992 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,393 pass(es).
[ View ]

thanks for the review @aspilicious. Here is the updated one with inspector screenshot...

+  mapping:
+    title:
+      type: integer
+      label: 'Allow link text'

This should be radio buttons, but it's understandable we can't determine that while processing the form...
Going to rtbc when it comes back green.

In the file patch we decided to got with the string for the radio, can't we do that here to?

Status:Needs review» Closed (duplicate)
Related issues:+#2167623: Add test for all default configuration to ensure schema exists and is correct

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.