API page: http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct...

Enter a descriptive title (above) relating to function hook_install_tasks, then describe the problem you have found:

The nested bullets in the @return for 'type' and 'run' are broken.

Files: 
CommentFileSizeAuthor
#5 drupal-hook_install_tasks-bullets-1984190-5.patch6.22 KBmarkpavlitski
PASSED: [[SimpleTest]]: [MySQL] 56,004 pass(es).
[ View ]
#3 drupal-hook_install_tasks-bullets-1984190-3.patch6.75 KBmarkpavlitski
PASSED: [[SimpleTest]]: [MySQL] 55,665 pass(es).
[ View ]
#1 drupal-hook_install_tasks-bullets-1984190-1.patch3.84 KBmarkpavlitski
PASSED: [[SimpleTest]]: [MySQL] 55,984 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new3.84 KB
PASSED: [[SimpleTest]]: [MySQL] 55,984 pass(es).
[ View ]

This looks like an indenting issue. Patch attached.

Status:Needs review» Needs work

Thanks! There is still some list formatting problem here:

*     - 'run'
  *       A constant representing the manner in which the task will be run. This

This should be:
*     - run: A constant representing the manner in which the task will be run. This

There should not be '' around 'run', and it should be followed by a : and the description. See
http://drupal.org/node/1354#lists

If you could fix up the whole @return area, that would be great!

Status:Needs work» Needs review
StatusFileSize
new6.75 KB
PASSED: [[SimpleTest]]: [MySQL] 55,665 pass(es).
[ View ]

@jhodgdon Thanks for the feedback.

Amended patch attached.

Status:Needs review» Needs work

Excellent! The only remaining list formatting problem is that the whole list should be indented less. It should be:

* @return array
*   Text text text text ... :
*   - list_item_1: text text text ...
*     more text more text:
*     - sub_list_item: text text text

not
* @return array
*   Text text text text ... :
*     - list_item_1: text text text ...
*       more text more text:
*       - sub_list_item: text text text

Thanks!

Status:Needs work» Needs review
StatusFileSize
new6.22 KB
PASSED: [[SimpleTest]]: [MySQL] 56,004 pass(es).
[ View ]

Apologies, I hadn't spotted that. Thanks again!

Assigned:Unassigned» jhodgdon
Status:Needs review» Reviewed & tested by the community

Perfect! Thanks for the quick work. I'll get this committed shortly (assuming the test turns green).

Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Fixed

Thanks again! Committed to 8.x and 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.