[D7] NVP Field

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxjohn_a1984082git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi john_a.
1.

/**
 * Implements hook_field_settings_form().
 */
function nvp_field_field_settings_form($field, $instance, $has_data) {
  if ($field['type'] == 'nvp_field') {
    $settings = $field['settings'];
    $form = array();
    return $form;
  }
} 

If you not use variable $settings, that you must remove it.

2.
Function nvp_field_field_instance_settings_form()
You use:

 $form = array(
    'name_title' => array(
      '#description' => t('The Name title field gives a recognisable name for the firstv alue to the user'),
      '#type' => 'textfield',
      '#title' => t('Name title'),
      '#default_value' => $settings['name_title'],
      '#size' => 60,
      '#maxlength' => 128,
      '#required' => FALSE,
    ), 

No need to write '#required' => FALSE, since this is the default setting FALSE

Hi,

Please fix the errors reported by:
http://ventral.org/pareview/httpgitdrupalorgsandboxjohna1984082git

Please note that you need to switch from the master branch to a new branch.
FYI: https://drupal.org/node/1127732

Then update the issue summary to reflect the correct branch in git clone.

Overall, the code seems neat and working.
Nice concept. However, I could not imagine any practical application of this module (No offense) . Please help me with an example.

Works just as described.
Templating(field--field_nvp.tpl.php) also works like it should.

update git clone command to reflect move from master

Looks pretty good to me too, no issues found. The ventral report comes back clean. The use case seems reasonable.

----
Top Shelf Modules - Enterprise modules from the community for the community.

No further action is required, but the best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://ventral.org is not enough.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Your project page needs a lot more detail - add some of the text from the README at least. In the .info file don't use abbreviations in the project description. Your schema defines the name/value columns as varchar 255, but the form has a #maxlength of 128. Why is the prefix/suffix set to 1000 chars - is that some kinds of Fields default? Looks pretty good though.

Thanks for your contribution, john_a!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.