Hi, i tried to use the target attribut as a token in views and it is empty.

Best regards
Lars

CommentFileSizeAuthor
#14 link-n1985050-14.patch871 bytesDamienMcKenna
#9 link-1985050-add-attribute-tokens-3_0.patch846 bytesj0sbeir
#7 link-1985050-add-attribute-tokens-2.patch960 bytesj0sbeir
#6 link-1985050-add-attribute-tokens-2.patch960 bytesj0sbeir
#3 link-1985050-add-attribute-tokens.patch992 bytesnightlife2008
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KarlShea’s picture

KarlShea
he/him
Primary language English
Location Minneapolis 🇺🇸
CreditAttribution: KarlShea commented
Version: 7.x-1.1 » 7.x-1.3
Issue summary: View changes

I am also not able to get at the target attribute through Token. I'm using latest Entity Token dev, latest Link, latest Token and the attributes token returns a struct wrapper, but when trying to nest any further the struct wrapper is null in the function to get the value for target.

aryser’s picture

aryser CreditAttribution: aryser commented
Related issues: +#1508614: Expose attributes properly to Views
nightlife2008’s picture

nightlife2008 CreditAttribution: nightlife2008 commented
FileSize
link-1985050-add-attribute-tokens.patch992 bytes

In attachment is the patch I created to support the attribute tokens.

B-Prod’s picture

B-Prod CreditAttribution: B-Prod commented
Status: Active » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: link-1985050-add-attribute-tokens.patch, failed testing.

j0sbeir’s picture

j0sbeir CreditAttribution: j0sbeir commented
FileSize
link-1985050-add-attribute-tokens-2.patch960 bytes

The patch attached works with 7.x-1.4

j0sbeir’s picture

j0sbeir CreditAttribution: j0sbeir commented
FileSize
link-1985050-add-attribute-tokens-2.patch960 bytes

Fixed patch path so it can be used properly with drush make

j0sbeir’s picture

j0sbeir CreditAttribution: j0sbeir commented
j0sbeir’s picture

j0sbeir CreditAttribution: j0sbeir commented
FileSize
link-1985050-add-attribute-tokens-3_0.patch846 bytes

Okay.. something went wrong with my upload :-)
Third time's the charm!

nightlife2008’s picture

nightlife2008 CreditAttribution: nightlife2008 commented

I just noticed my faulty patching :(

anneeasterling’s picture

anneeasterling CreditAttribution: anneeasterling as a volunteer commented

This patch enabled me to use a token formatted like this to access the target attribute:

[entity_name:field_custom_link:attributes:target]

In other words, I've tested and works. It would be awesome if this were officially tested and committed.

Thanks!

scott_earnest’s picture

scott_earnest CreditAttribution: scott_earnest commented

Perhaps: https://www.drupal.org/project/link/issues/1508614#comment-13382074

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-1.3 » 7.x-1.x-dev
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
link-n1985050-14.patch871 bytes

Rerolled.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work
Issue tags: +Needs tests

The existing test coverage needs expanding.