There is some code in mytube.module for D6 (I haven't tested in D7) that checks if the embed domain is the current domain, and if so, doesn't do the image replacement, but it seems to be relying on a global variable that isn't set anywhere else. Rather than setting that variable elsewhere, it seems to make sense to me to use the core Drupal base_url variable. Patch forthcoming.

CommentFileSizeAuthor
#1 mytube-base_domain_fix-1985090-1.patch896 bytesmcarbone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcarbone’s picture

Status: Active » Needs review
FileSize
896 bytes
l@va’s picture

Awesome, thank you so much for your patch! I'm really busy for the next few days, but I'll take a closer look and submit it shortly. I think D7 is using embed_url instead of _mytube_base_url (and peculiarly sets _mytube_base_url but never uses it) so using embed_url might be preferential.

Leaving issue open until further notice.

mfb’s picture

Issue summary: View changes
Status: Needs review » Fixed

In the Drupal 7 branch, it appears that the trusted domain functionality causes an empty domain to be trusted. In addition, the base domain(s) of the site can be defined there. So I believe this is fixed in that branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.