ThemeKey doesn't work when Nodewords Open Graph module is enabled [#1986230]

Hi,

I've encountered a rather strange bug on a client's site. They are using Organic Groups with custom themes and had Nodewords basic running for quite some time. Recently they needed the ability to control what's shared on Facebook, so we enabled nodewords_og. Doing so resulted in all groups with custom themes showing the main site theme.

I was able to trace the problem down to nodewords_og_nodewords_tags_info(). Not sure what exactly is happening as:

adding a return at the beginning of the function brings back the custom themes
we suspected it may be a namespace conflict, OG API coincidence with the tags callbacks, but renaming them didn't work.
renaming the module to nodewords_opengraph and replacing all "og" occurrences other than the actual tags to "opengraph" did not help either

The way OG works is by determining the context in hook_init() and if the user is on a OG, it sets the theme to the group's theme by changing the global variable $custom_theme among other things. To determine context, it calls node_load(). Normally all this happens before the theme layer kicks in, so init_theme() can pick up any changes to $custom_theme

However, nodewords implements hook_nodeapi() and it is in $op == 'load' where it tries to load all its tags. And somehow this triggers init_theme() before OG sets its context and custom theme.

The only solution I could find was to change $op from "load" to "view", but I am not sure what the implications on other modules are.

Any ideas?

Thank you,
Dan

Comment	File	Size	Author
#16	nodewords-og-theme-fix-1986230-16.patch	986 bytes	zerolab
#13	nodewords-og-theme-fix-1986230-13.patch	1 KB	zerolab
#8	nodewords-n1986230-8.patch	616 bytes	DamienMcKenna

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

nicholas.alipaz CreditAttribution: nicholas.alipaz commented 13 May 2013 at 22:17

This seems to affect people using admin themes too. Our admin theme is not used in various places node/*/edit for example.

Comment #2

kepford CreditAttribution: kepford commented 21 April 2014 at 19:25

I can confirm that this issue exists outside of Organic Groups. I was able to reproduce this with both themekey module and a custom theme switching module.

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 April 2014 at 20:01

Does this also happen if the 'nodewords_extra' submodule is enabled instead of the OG submodule?

Comment #4

kepford CreditAttribution: kepford commented 21 April 2014 at 20:21

No, the issue does not occur with nodewords_extra enabled.

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 April 2014 at 20:54

Version:

6.x-1.14

» 6.x-1.x-dev

I have a testbed with the Nodewords dev release, Themekey and the following other modules:

block
color
comment
dblog
filter
help
menu
node
php
system
taxonomy
update
user
admin_menu
ctools
page_manager
devel
memcache_status
nodewords
nodewords_basic
nodewords_extra
nodewords_og
panels
panels_mini
phonetic
themekey
themekey_ui
token

The theme selection works just fine with the default Themekey settings and a configuration that changes the theme for a specific content type.

Could you please test out Nodewords v1.15-beta1 to see if that makes any difference?

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 April 2014 at 20:58

Status:

Active

» Postponed (maintainer needs more info)

Other than a namespace conflict purely because the module is named "nodewords_og" (thus matches the string "{$modulename}_og"), I don't see how this could be caused by Nodewords. I'm changing the status to Postponed until someone can show otherwise.

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 April 2014 at 18:01

Title:	Organic Group loses custom theme when Nodewords Open Graph module is enabled	» ThemeKey doesn't work when Nodewords Open Graph module is enabled
Status:	Postponed (maintainer needs more info)	» Fixed

So it turns out that the problem is because of module weights, the solution is to change the weight of the ThemeKey module until the switching starts working again. Check out #754970: Skipped rule checking because another module already initialized the theme engine for a long discussion about it. Thanks to kepford for finding that one.

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 April 2014 at 18:25

Status:

Fixed

» Needs review

File	Size
nodewords-n1986230-8.patch	616 bytes

I'm going to add this note to the README.txt file.

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 28 April 2014 at 18:32

Committed.

Comment #10

28 April 2014 at 18:35

Commit 4b57434 on 6.x-1.x by DamienMcKenna:

Issue #1986230 by DamienMcKenna: Added a note to README.txt about the...

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 10 June 2014 at 15:12

Status:

Needs review

» Fixed

Comment #12

24 June 2014 at 15:20

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #13

zerolab CreditAttribution: zerolab at Torchbox for The Chartered Society of Physiotherapy commented 17 February 2016 at 15:40

File	Size
nodewords-og-theme-fix-1986230-13.patch	1 KB

Hi,

I know this has been marked as closed for a while now, but changing weights did not solve the issue in the Organic Groups context.
Finally got some time to revisit this and found the issue: nodewords_og_get_tags() uses a %count token for the "og:description" description. As per https://api.drupal.org/api/drupal/includes%21common.inc/function/t/6, "%variable: escape text and theme as a placeholder for user-submitted content (check_plain + theme_placeholder)" -- thus triggers init_theme()

Attaching patch that changes %count to @count which fixes the issue.