[D7] Fruit Blossom

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxAarup1986482git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

You should switch from the master branch, see http://drupal.org/node/1127732

You also have errors to resolve here http://ventral.org/pareview/httpgitdrupalorgsandboxAarup1986482git
just a few are:
README.txt is missing, see the guidelines for in-project documentation.

Remove LICENSE.txt, it will be added by drupal.org packaging automatically.

Remove "version" from the ./fruit_blossom.info file, it will be added by drupal.org packaging automatically.

./template.php: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
function delicious_fruit_node_submitted($node) {

Remove all old CVS $Id tags, they are not needed anymore.
page.tpl.php:2:// $Id:
style.css:1:/* $Id: */
template.php:2:// $Id:

Everything looks real good, Clean design. I would say go for the review bonus and see if you can get it submitted!

Hi Bent Aarup,

I had reviewed your theme and code as well. Some Bugs are listed below.

UI bugs:

1. Layout for errors are not properly formatted. I had just make a mistake to see error message then it shows me a disturbed layout of error messages. Please check screenshot (Error.png).
2. I had showed login form to header right region but it overlapped with the design that disturbed the whole layout. Please check screenshot (login-form.png).
3. I had created three blocks and showed in different regions. It is going overlap. Please see the Screenshot (Overlapping blocks.png).
4. You have added an image for the whole layout on page id in CSS file which is not correct. When page content will increase,layout will definitely break. So Please make an alternate for the same.

Coding bugs:

1. Code in Info file is not as per drupal Standard and you have not mention features and Version. Please check out the Standard of Info file firstly.
2. It would be good if you create css and template folder for css file and tpl files.
3. These are not necessary but it would be good if you add the following files:

favicon.ico
LICENSE.txt
theme-settings.php.

These are missing in your theme Directory.

Hi Bent Aarup,

Some other bugs i found in a manual review:

1. I had added a content (3 or 4 line) in Article type. It shows white space in bottom. Please see the screenshot (white-space.png) Add following code in CSS file for solved out.

.node.clearfix:after {
clear: none;
}

2. In my account same un-necessary space. Please see the screenshot (user-blank-space.png). And remove the "Clear:both" css from user.css file.

.profile {
clear: both;
}

3. Backgrounds are overlapped when i'll show search bar into header right region. Please see the screenshot (overlap-images.png)

4. Image touch with the submitted text. There is need some space between them. See the screenshot (add-space.png).

5. As you said earlier, I agree layout is open in the bottom but if i place login block or any type of text in header region it breaks the theme as well. Because it is an background image and obviously it will create problem in future when user place content in header.

6. And one suggestion for the main menu is that you have add image on hover links but the links in which there are sub-links, that have no background image or color change on hover. Please take a look on this if i am right.

Hello,

Manual Review :

- template.php
(1) Remove un-wanted/blank functions
/**
* Remove forum navigation.
*/
function fruit_blossom_forum_topic_navigation($node) {
}

Thanks,
Ujval

git clone information corrected.

Hi Bent,

I downloaded your theme and tested it manually on my localhost XAMPP server. It's good looking theme I relay appreciate it. Nice work!!

I like theme much more if you think below changes appropriate.

• After disabling logo from theme setting I found empty logo div still there <div id="header-logo"> </div>. It will better in page.tpl.php you wrap it into if loop like
  

  	<?php if (!empty($logo)): ?>
        <div id="header-logo">        
            <a href="<?php print $front_page; ?>" title="<?php print t('Home'); ?>" rel="home" id="logo">
              <img src="<?php print $logo; ?>" alt="" />
            </a>        
        </div> <!-- /header-logo -->
  	  <?php endif; ?>

. But you also need some graphical changes for this. This is applicable for all div/blocks. This approach of development crop/cut unnecessary empty div/blocks.

Except above minor things theme is excellent! cheers!!!

itapplication
(Shiv)

Hi Bent,

I am waiting for your reply for my suggestion at #14. Do you have any problem to update code as per my suggestion. please inform me. I am available to help you.

Could you use a bigger photo for https://drupal.org/files/project-images/screenshot_79.png on the project page? It's so tiny I can't tell what I'm looking at. How is a 148px by 137px png using up 60 Kb of storage anyway?
You have a typo in your README, "backround" should be "background".

None of those are blocking issues, otherwise the code seems good! I'm unassigning this issue so other folks know it's ok to review it. Sometimes if people see a name assigned, they think that person is handling it.

----
Top Shelf Modules - Crafted, Curated, Contributed.

live demo site added

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Bent Aarup!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Better status :)

fixed typo