Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#9 drupal-1987576-9.patch3.55 KBmrded
FAILED: [[SimpleTest]]: [MySQL] 58,380 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#7 drupal-1987576-7.patch3.49 KBmrded
FAILED: [[SimpleTest]]: [MySQL] 58,520 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

Assigned:Unassigned» acrollet

taking a look at this today.

Assigned:acrollet» Unassigned

going to look for a non-test module issue per Larry.

Status:Active» Closed (won't fix)

Status:Closed (won't fix)» Active

Assigned:Unassigned» Sean Buscay

Assigned:Sean Buscay» mrded
Issue tags:+LONDON_2013_AUGUST

Working on this as part of London sprint.

Status:Active» Needs review
StatusFileSize
new3.49 KB
FAILED: [[SimpleTest]]: [MySQL] 58,520 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Please, take a look my patch.

Status:Needs review» Needs work

Thanks for the quick re-roll @mrded.

+++ b/core/modules/system/tests/modules/session_test/lib/Drupal/session_test/Controller/SessionTestController.php
@@ -0,0 +1,30 @@
+ * Contains \Drupal\session_test\Controller\SessionTestController.
...
+class SessionTestStartController implements ControllerInterface {

Can we update the class name to the one in comment?

+class SessionTestStartController implements ControllerInterface {

+++ b/core/modules/system/tests/modules/session_test/lib/Drupal/session_test/Controller/SessionTestController.php
@@ -0,0 +1,30 @@
+    return 'session_id:' . $_COOKIE[session_name()] . "\n";
diff --git a/core/modules/system/tests/modules/session_test/session_test.module b/core/modules/system/tests/modules/session_test/session_test.module
index b6e1a53..d003498 100644

we need to use Request.

Status:Needs work» Needs review
StatusFileSize
new3.55 KB
FAILED: [[SimpleTest]]: [MySQL] 58,380 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Take a look to new patch.

Status:Needs review» Needs work

The last submitted patch, drupal-1987576-9.patch, failed testing.

Status:Needs work» Closed (duplicate)

Please work on this here: #1987572: Convert session_test callbacks to a new style controller. There's already a patch that has conversions for all the session_test callbacks. It just needs the tests fixed.