Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#20 drupal8.system-module.1987656-20.patch3.27 KBmparker17
PASSED: [[SimpleTest]]: [MySQL] 58,844 pass(es).
[ View ]
#20 interdiff.txt777 bytesmparker17
#18 drupal8.system-module.1987656-18.patch3.22 KBmparker17
PASSED: [[SimpleTest]]: [MySQL] 59,002 pass(es).
[ View ]
#12 drupal8.system-module.1987656-11.patch3.29 KBmparker17
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.system-module.1987656-11_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#12 interdiff.txt670 bytesmparker17
#11 drupal8.system-module.1987656-11.patch3.29 KBmparker17
PASSED: [[SimpleTest]]: [MySQL] 59,084 pass(es).
[ View ]
#11 interdiff.txt670 bytesmparker17
#7 drupal8.system-module.1987656-7.patch3.29 KBmparker17
PASSED: [[SimpleTest]]: [MySQL] 58,098 pass(es).
[ View ]
#7 interdiff.txt1.51 KBmparker17
#4 system-common_test-js_css_querystring_controller-1987656-4.patch3.3 KBmparker17
PASSED: [[SimpleTest]]: [MySQL] 58,190 pass(es).
[ View ]

Comments

Status:Active» Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

Status:Closed (won't fix)» Active

Assigned:Unassigned» mparker17

I'll help!

Assigned:mparker17» Unassigned
Status:Active» Needs review
StatusFileSize
new3.3 KB
PASSED: [[SimpleTest]]: [MySQL] 58,190 pass(es).
[ View ]

Try this...

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -59,4 +59,18 @@ public function typeLinkActiveClass() {
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
...
+    drupal_set_title('Test querystring');
...
+    return '';

drupal_set_title can be replaced by return array('#title' => 'Test querystring'); If we do that, just put a @return statement in there as well.

Status:Needs review» Needs work

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -59,4 +59,18 @@ public function typeLinkActiveClass() {
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
...
+    drupal_set_title('Test querystring');
...
+    return '';

drupal_set_title can be replaced by return array('#title' => 'Test querystring'); If we do that, just put a @return statement in there as well.

Status:Needs work» Needs review
StatusFileSize
new1.51 KB
new3.29 KB
PASSED: [[SimpleTest]]: [MySQL] 58,098 pass(es).
[ View ]

Try this...

+++ b/core/modules/system/tests/modules/common_test/common_test.routing.yml
@@ -4,3 +4,10 @@ common_test_l_active_class:
+  pattern: 'common-test/query-string'

Sorry, pattern should start with "/"

Status:Needs review» Needs work

K

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

Status:Needs work» Needs review
StatusFileSize
new670 bytes
new3.29 KB
PASSED: [[SimpleTest]]: [MySQL] 59,084 pass(es).
[ View ]

Try this...

StatusFileSize
new670 bytes
new3.29 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.system-module.1987656-11_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Try this...

Status:Needs review» Needs work
Issue tags:-WSCCI-conversion

The last submitted patch, drupal8.system-module.1987656-11.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, drupal8.system-module.1987656-11.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+WSCCI-conversion

The last submitted patch, drupal8.system-module.1987656-11.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new3.22 KB
PASSED: [[SimpleTest]]: [MySQL] 59,002 pass(es).
[ View ]

Straight re-roll of the patch; no interdiff.

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -73,4 +73,16 @@ public function drupalRenderInvalidKeys() {
+  /**
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
+  public function jsAndCssQuerystring() {

Can we have just a simple @return statement, please?

StatusFileSize
new777 bytes
new3.27 KB
PASSED: [[SimpleTest]]: [MySQL] 58,844 pass(es).
[ View ]

OK...

Status:Needs review» Reviewed & tested by the community

Thank you very much!!

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.