Support from Acquia helps fund testing for Drupal Acquia logo

Comments

h3rj4n’s picture

Status: Active » Needs review
FileSize
2.86 KB

The patch to convert this to a controller.

tim.plunkett’s picture

+++ b/core/modules/config/tests/config_test/config_test.routing.ymlundefined
@@ -0,0 +1,6 @@
+    _content: '\Drupal\config_test\Controller\ConfigTestController::addConfigTest'

You should be able to just have _entity_form: 'config_test', and then you can ditch the whole ConfigTestController

h3rj4n’s picture

Changed it and it seems to work fine.

Removed the controller, changed the routing file to _entity_form.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

He, making progress by basically just removing code. Tests are running fine, so this feels great.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs reroll...

curl https://drupal.org/files/drupal-convert_config_test_add_page-1987662-3.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1602  100  1602    0     0  17189      0 --:--:-- --:--:-- --:--:-- 20538
error: core/modules/config/tests/config_test/config_test.routing.yml: already exists in index
mparker17’s picture

Assigned: Unassigned » mparker17

I'll help!

mparker17’s picture

Assigned: mparker17 » Unassigned
Status: Needs work » Needs review
FileSize
1.69 KB

Rerolled!

No interdiff because the old patch didn't apply. Also, it's literally just a re-roll.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

jibran’s picture

Status: Reviewed & tested by the community » Closed (duplicate)