Part of #1971384: [META] Convert page callbacks to controllers and helps towards #1830588: [META] remove drupal_set_title() and drupal_get_title()
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
I'll take entity_test module starting with this issue.
I will likely run out of time to work on this patch. Unassigning myself.
The last submitted patch, drupal8.entity_test.1987694-6.patch, failed testing.
Changing _access to _permission since it's not a callback.
The last submitted patch, drupal8.entity_test.1987694-8.patch, failed testing.
Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Re-roll+ drupal_set_title() update...
The last submitted patch, 11: 1987888-entity_test-controller-11.patch, failed testing.
11: 1987888-entity_test-controller-11.patch queued for re-testing.
Re-roll, resolved conflict in entity_test.module
The last submitted patch, 15: 1987888-entity_test-controller-15.patch, failed testing.
15: 1987888-entity_test-controller-15.patch queued for re-testing.
@Wim Leers have you been looking into this or did you just want fresh test results before you started? I've been having a look this evening, I spotted that the new code is calling entityManager() when I think it should be entityFormBuilder() and was about to test a patch to change that, but can leave you to it if you're already working on it.
As mentioned, entityManager() > entityFormBuilder(). Fixes the tests I've tried locally.
Bumping to major since this blocks #1830588: [META] remove drupal_set_title() and drupal_get_title()
+++ b/core/modules/system/tests/modules/entity_test/lib/Drupal/entity_test/Controller/EntityTestController.php@@ -7,27 +7,48 @@+ * @see entity_test_menu()
Does entity_test_menu() still exist?
Apart from that question this all looks good to me. Happy to RTBC.
Yeah, entity_test_menu() was removed in 8608fed
We should probably update the docblock.
Here's an updated patch.
That was moved to \Drupal\entity_test\Routing\EntityTestRoutes::routes(), this patch puts an appropriate @see on each method, rather than just removing it.
This looks good to me.
Committed and pushed to 8.x. Thanks!
Drupal is a registered trademark of Dries Buytaert.