Comments

Status:Active» Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

Status:Closed (won't fix)» Active

Assigned:Unassigned» partyka

Reopening.

StatusFileSize
new3.58 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in 1987720-form-test-wrapper-callback.patch.
[ View ]

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
The patch is provided as noted in the terms of the copyright notice.

The form_test_wrapper_callback is converted to use a controller instead of hook_menu

This patch is being submitted by Argonne National Laboratory, August 15, 2013

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Status:Active» Needs review

Setting patch to needs review.

Status:Needs review» Needs work

The last submitted patch, 1987720-form-test-wrapper-callback.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new3.5 KB
PASSED: [[SimpleTest]]: [MySQL] 58,040 pass(es).
[ View ]

Updated patch for line-endings.

Status:Needs review» Needs work
  1. +++ drupal/core/modules/system/tests/modules/form_test/form_test.module (revision )
    @@ -119,9 +119,7 @@
       $items['form_test/wrapper-callback'] = array(
         'title' => 'Form wrapper callback test',
    -    'page callback' => 'form_test_wrapper_callback',
    -    'page arguments' => array('form_test_wrapper_callback_form'),
    -    'access callback' => TRUE,
    +    'route_name' => 'form_test.route8',
         'type' => MENU_CALLBACK,
       );

    Let's drop this hook_menu() entry.

  2. +++ drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/Controller/FormTestController.php (revision )
    @@ -0,0 +1,17 @@
    +<?php
    +
    ...
    +
    +class FormTestController {
    ...
    +  public function testWrapper($form_id) {

    Let's add some simple lines.

  3. +++ drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/Controller/FormTestController.php (revision )
    Index: drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/ConfirmFormArrayPathTestForm.php
    ===================================================================
    ===================================================================
    --- drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/ConfirmFormArrayPathTestForm.php (revision cd15b235db7353771053ad56018e4a65abffdd6f)
    --- drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/ConfirmFormArrayPathTestForm.php (revision cd15b235db7353771053ad56018e4a65abffdd6f)
    +++ drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/ConfirmFormArrayPathTestForm.php (revision )
    +++ drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/ConfirmFormArrayPathTestForm.php (revision )
    +++ drupal/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/ConfirmFormArrayPathTestForm.php (revision )
    @@ -38,4 +38,6 @@
    @@ -38,4 +38,6 @@
         return t('ConfirmFormArrayPathTestForm::getCancelText().');
       }
    +
    +
    }

    No need for this change

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new3.67 KB
FAILED: [[SimpleTest]]: [MySQL] 60,125 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Re-roll that fixes all review comments in #8

Status:Needs review» Needs work

The last submitted patch, 10: 1987720-form_test-controller-10.patch, failed testing.

Assigned:partyka» Unassigned
Issue tags:+Needs reroll

reroll instructions: https://drupal.org/contributor-tasks/reroll

@partyka, it has been a few months. unassigning. no worries. :)

Assigned:Unassigned» Sam Hermans

I'll check this out

Assigned:Sam Hermans» Unassigned
Status:Needs work» Needs review
Issue tags:-Needs reroll
StatusFileSize
new3.67 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Re rolled patch agains latest HEAD.

StatusFileSize
new4.3 KB
FAILED: [[SimpleTest]]: [MySQL] 63,104 pass(es), 2 fail(s), and 1 exception(s).
[ View ]

Fixed failing tests

The last submitted patch, 14: 1987720-form_test-controller-14.patch, failed testing.

Status:Needs review» Needs work
  1. +++ b/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/Controller/FormTestController.php
    @@ -8,11 +8,40 @@
    use Drupal\Core\Controller\ControllerBase;
    use Drupal\Core\Language\Language;
    +use Drupal\Core\Form\FormBuilderInterface;
    +use Symfony\Component\DependencyInjection\ContainerInterface;
    +use Drupal\Core\DependencyInjection\ContainerInjectionInterface;

    These can be put in alphabetical order.

  2. +++ b/core/modules/system/tests/modules/form_test/lib/Drupal/form_test/Controller/FormTestController.php
    @@ -8,11 +8,40 @@
    +  /**
    +   * Constructs a new search controller.
    +   *

    This is not a search controller. This can be changed to:

    Constructs a new FormTestController.

Assigned:Unassigned» Sam Hermans

Assigned:Sam Hermans» Unassigned
Status:Needs work» Needs review
StatusFileSize
new1.21 KB
new4.34 KB
PASSED: [[SimpleTest]]: [MySQL] 63,183 pass(es).
[ View ]

Thank you for your reviewing this .. i adressed your remarks and added them in a seperate interdiff.txt

The last submitted patch, 15: 1987720-form_test-controller-15.patch, failed testing.

This conflicts with #2110951: Remove hook_forms() and may even be a duplicate.