Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Beta phase evaluation
Issue category | Task because it updates the code to the new APIs/code style |
---|---|
Unfrozen changes | Unfrozen because changes automated tests |
Comment | File | Size | Author |
---|---|---|---|
#7 | 1987738_7.patch | 2.26 KB | Mile23 |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
rabellamy CreditAttribution: rabellamy commentedComment #4
partyka CreditAttribution: partyka commentedComment #5
partyka CreditAttribution: partyka commentedPer discussion with Crell, the following test is being removed as it is longer necessary due to the concept of load arguments being gone in the routing system:
menu-test/arguments/%menu_test_argument/%/explicit-arguments
menu-test/arguments/%menu_test_argument/%menu_test_other_argument/common-loader
menu-test/arguments/%/%menu_test_argument/different-loaders-1
menu-test/arguments/%menu_test_other_argument/%/different-loaders-2
menu-test/arguments/%/%/different-loaders-3
menu-test/arguments/%menu_test_argument/%
menu-test/arguments/%menu_test_argument/%/default
menu-test/arguments/%menu_test_argument/%/task
Comment #6
xjmThanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Comment #7
Mile23Fix'd.
Comment #8
Mile23Comment #9
valthebaldUpdated issue summary (+Beta stage evaluation), changing to RTBC
Comment #10
valthebaldComment #12
valthebaldComment #13
Mile23I just did a reroll and the patches are the same. So it just needs to update to match new behavior.
Comment #14
valthebaldBut I see that tests failed with the patch? Should it be adjusted?
Comment #16
aspilicious CreditAttribution: aspilicious commentedTestbot hickup it was
Comment #17
alexpottCommitted 1add901 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.