Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#9 1987832-system_test-controller-9.patch7.45 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 59,711 pass(es), 25 fail(s), and 8 exception(s).
[ View ]
#6 drupal8.system_test.1987832-6.patch10.4 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 58,284 pass(es), 8 fail(s), and 2 exception(s).
[ View ]
#6 interdiff.txt1.37 KBdisasm
#4 drupal8.system_test-module.1987832-4.patch10.44 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 58,071 pass(es), 11 fail(s), and 2 exception(s).
[ View ]

Comments

Status:Active» Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

Status:Closed (won't fix)» Active

Assigned:Unassigned» Sean Buscay

Title:Convert system_test_authorize_init_page() to a new style controllerConvert system_test callbacks to a new style controller
Assigned:Sean Buscay» disasm
Status:Active» Needs review
StatusFileSize
new10.44 KB
FAILED: [[SimpleTest]]: [MySQL] 58,071 pass(es), 11 fail(s), and 2 exception(s).
[ View ]

attached is a first run at this patch.

Status:Needs review» Needs work

The last submitted patch, drupal8.system_test-module.1987832-4.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.37 KB
new10.4 KB
FAILED: [[SimpleTest]]: [MySQL] 58,284 pass(es), 8 fail(s), and 2 exception(s).
[ View ]

I doubt this will fix the tests, but it makes the class a little cleaner. Someone that knows how drupal_register_shutdown_function works is probably going to have to dig into or give guidance on this issue.

Status:Needs review» Needs work

The last submitted patch, drupal8.system_test.1987832-6.patch, failed testing.

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new7.45 KB
FAILED: [[SimpleTest]]: [MySQL] 59,711 pass(es), 25 fail(s), and 8 exception(s).
[ View ]

Re-issuing patch with current code base.

Status:Needs review» Needs work

The last submitted patch, 9: 1987832-system_test-controller-9.patch, failed testing.