Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Files: 
CommentFileSizeAuthor
#15 taxonomy-1987860-15.patch6.93 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 56,449 pass(es).
[ View ]
#15 interdiff.txt569 bytestim.plunkett
#13 taxonomy-1987860-13.patch6.93 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 56,678 pass(es).
[ View ]
#10 taxonomy-1987860-10.patch8.26 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 56,452 pass(es).
[ View ]
#10 interdiff.txt3.72 KBtim.plunkett
#6 taxonomy-1987860-6.patch6.89 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,561 pass(es).
[ View ]
#6 interdiff.txt4.88 KBtim.plunkett
#4 taxonomy-1987860-4.patch4.61 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,049 pass(es), 3 fail(s), and 0 exception(s).
[ View ]

Comments

Status:Active» Postponed

Blocked by #1978166: Convert block/add/{%custom_block_type} to Controller as it has support for default value.

Status:Postponed» Active

Not blocked anymore

Status:Active» Needs review
StatusFileSize
new4.61 KB
FAILED: [[SimpleTest]]: [MySQL] 58,049 pass(es), 3 fail(s), and 0 exception(s).
[ View ]

This needs a new access checker, but I just wanted to get the start of it up.

Status:Needs review» Needs work

The last submitted patch, taxonomy-1987860-4.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new4.88 KB
new6.89 KB
PASSED: [[SimpleTest]]: [MySQL] 58,561 pass(es).
[ View ]

Hopefully #2028585: Replace entity_page_create_access by an access controller will replace entity_page_create_access(), but we should continue using it for now.

looks good to me. RTBC from my side.

#6: taxonomy-1987860-6.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Great!

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new3.72 KB
new8.26 KB
PASSED: [[SimpleTest]]: [MySQL] 56,452 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-WSCCI-conversion, -MENU_LOCAL_ACTION

The last submitted patch, taxonomy-1987860-10.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+WSCCI-conversion, +MENU_LOCAL_ACTION

#10: taxonomy-1987860-10.patch queued for re-testing.

StatusFileSize
new6.93 KB
PASSED: [[SimpleTest]]: [MySQL] 56,678 pass(es).
[ View ]

That went in.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Access/TaxonomyTermCreateAccess.phpundefined
@@ -0,0 +1,34 @@
+ * Contains Drupal\taxonomy\Access\TaxonomyTermCreateAccess.

Missing "\"

StatusFileSize
new569 bytes
new6.93 KB
PASSED: [[SimpleTest]]: [MySQL] 56,449 pass(es).
[ View ]

:)

Status:Needs review» Reviewed & tested by the community

Perfect

Status:Reviewed & tested by the community» Needs work
Issue tags:-WSCCI-conversion, -MENU_LOCAL_ACTION

The last submitted patch, taxonomy-1987860-15.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+WSCCI-conversion, +MENU_LOCAL_ACTION

#15: taxonomy-1987860-15.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Issue tags:+RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

Status:Reviewed & tested by the community» Fixed

Committed 67ffbd3 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.