Show a warning when the account for user #1 is edited

Still relevant.

I can't find any Rules page in Drupal core, but there is still no help text for user/1/edit, so still a valid issue in Drupal 7.4.

user/1/edit is just the Edit profile page. Is there any reason to have help text on this page that is not the same as on every user/%/edit page?

If text should be added, what should it be?

> user/1/edit is just the Edit profile page. Is there any reason to have help text on this page that is not the same as on every user/%/edit page?

Something saying 'This is the admin user. Changes made here could lock you out of your site completely.' might be handy here.

Having a warning (or help text) about User 1 would be nice.

Is there any UX enhancement planed for the user profile edition form?

This patch displays the warning in the issue summary in user/1/edit.

I Reviewed the patch and the "warning" message is:

Warning message Be careful, you are editing the admin user. Changes made here could lock you out of your site completely.

It works great.

To the committers: Note that this patch was part of sprint mentoring to @Buoro.Angelo. I wrote the patch while showing him how to write patches, and he provided some input to the code. Please assign credit to him.

This is not in line with our UI standards, were we explicitly avoid words such as "Please" and/or other forms of asking the user to apply a certain emotional state.

If users are logged in with this account it makes sense, in all other cases I am not sure about special casing it?

We can do something much more friendly and more explicit about which change might lock them out?

Drupal_set_message is deprecated and replaced by Messenger service.

Yes, drupal_set_message could be replaced with Messenger service.. Bit of amend in the #18 patch since it includes .lock file changes as well..

In #9 drupal_set_message is added, instead Messenger Service is amended..

Re-rolled for 9.2

Verified and tested patch#27. Patch applied successfully.

Testing steps:
1. Login as admin, after applying patch
2. Goto "/user/1/edit" page
3. Check warning message "Be careful, you are editing the admin user. Changes made here could lock you out of your site completely." is displayed.

Test Result: Warning message "Be careful, you are editing the admin user. Changes made here could lock you out of your site completely." is displayed on "/user/1/edit" page

RTBC +1

Hi @sonam.chaturvedi, thanks for the review! There is no need to assign yourself doing reviews cause issue may need multiple reviews to assure quality or discuss matters of the solution - especially in core. That said, very nice and detailed review!

I'm adding +1 to RTBC, tested it, works as intended and is a nice warning to have and helps user inclusiveness.

Please switch to RTBC whenever you feel that you reviewed and tested the patch.

Based on #29 and #30, switched to RTBC.

Reading the issue I don't see that this point from from the usability review in #14 has been addressed.

We can do something much more friendly and more explicit about which change might lock them out?

And I must admit I had the same thought when I read the message.

And should this be changed in anticipation of #540008: Add a container parameter that can remove the special behavior of UID#1?

Taking in consideration comment #33, should we wait the commit of issue #540008: Add a container parameter that can remove the special behavior of UID#1, to update this documentation accordingly?

Applied patch working fine and applied successfully
After patch warning message added successfully.
For ref sharing screenshots.....

@vikashsoni, Including a screenshot and duplicating the work of others is not necessary and does not help resolve an issue. Therefore removing credit per How is credit granted for Drupal core issues.

Adding patch

@dharmeshmertwal Instead of using the drupal service directly, best approach is to use Dependency injection and attach messenger service.

I am changing status as per previous comment.

I am editing the IS, since this issue isn't about adding help text but showing a warning when the account for user #1 is edited.

Since Drupal introduced the administrator role, should not the warning be shown when the account for a user with that role is edited? By default that is the role assigned to user #1.

Are there edits for which this warning should be shown? I won't show it when the contact settings are changed.

Since Drupal is going to stop to handle user #1 in a special way, does showing this warning still make sense?

Indeed. As currently written this is a vestigial issue that is wasting contributors’ time.

Adding new patch

Moving this backward from Needs Review as the patch has the phpcs error. However, apart from this, the point mentioned on #14 (reminded in #32) has not been addressed yet.

Also, as per the comment on #44 and #45, What can be done to move this forward?

Fixed Failed Commands against #46
Attached interdiff

I will begin by removing tags that attract the wrong kind of attention to the issue.

Please stop posting patches here until someone refocuses this issue.

Comment #14 has not been addressed.

If users are logged in with this account it makes sense, in all other cases I am not sure about special casing it?

If the user #1 account is edited by a user administrator, Changes made here could lock you out of your site completely. does not make much sense, as the edited account is not the account used to log in.