Follow-up to #1732880: Implement EpicEditor:

The editor.unload() code in Drupal.wysiwyg.editor.detach.epiceditor needs to test for a trigger value of "unload" or it'll remove the editor any time the form is affected via AJAX, such as when you upload a file to a file field. Patch to follow.

Sorta related issue: #1988118: Add EpicEditor issue component

CommentFileSizeAuthor
#1 wysiwyg-epiceditor-ajax-bug-1988128-1.patch476 bytesTravisCarden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented
Status: Active » Needs review
FileSize
wysiwyg-epiceditor-ajax-bug-1988128-1.patch476 bytes
yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Needs review » Reviewed & tested by the community

Tested with multi value field and clicked on 'add another item', editor disappeared. After applied the patch the editor didn't disappeared. Why do you use === instead of ==?

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented

@yannickoo, re #2: because the linters like it better, if I recall. :) It's more precise.

TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD commented
Issue summary: View changes
Status: Reviewed & tested by the community » Closed (duplicate)

Thanks for the patch, and I'm sorry I didn't get to this earlier.
I incorporated a similar change into the patch in the linked issue, please test it instead.