Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The following piece of code does not follow the Coding Standards for indentation.
function user_register_form($form, &$form_state) {
global $user;
$admin = user_access('administer users');
// Pass access information to the submit handler. Running an access check
// inside the submit function interferes with form processing and breaks
// hook_form_alter().
$form['administer_users'] = array(
'#type' => 'value',
'#value' => $admin,
);
Comment | File | Size | Author |
---|---|---|---|
#9 | 1988456_user_register_form_coding_standard_fix.patch | 556 bytes | gaurav.goyal |
#3 | update-coding-standard-for-user-module-1988456-2.patch | 554 bytes | eltermann |
#1 | do-1988456-update-coding-standard-for-user-module.patch | 17.76 KB | pvmchau |
Comments
Comment #1
pvmchau CreditAttribution: pvmchau commentedUpdate coding standards for user.module
Comment #2
thehong CreditAttribution: thehong commentedI think you should remove those lines.
Comment #3
eltermann CreditAttribution: eltermann commentedComment #4
nkhanh90 CreditAttribution: nkhanh90 commented#3: update-coding-standard-for-user-module-1988456-2.patch queued for re-testing.
Comment #5
parthipanramesh CreditAttribution: parthipanramesh commentedLatest patch does apply indentions correctly.
Comment #6
David_Rothstein CreditAttribution: David_Rothstein commentedNope, oops... it needs to be two spaces of indentation, not one space :)
Comment #7
lachezar.valchev CreditAttribution: lachezar.valchev commentedComment #8
gaurav.goyal CreditAttribution: gaurav.goyal commentedComment #9
gaurav.goyal CreditAttribution: gaurav.goyal commentedIndentation Corrected.
Comment #10
David_Rothstein CreditAttribution: David_Rothstein commentedThat looks great - thanks!
The bug doesn't appear to be present in Drupal 8 (must have been fixed somewhere along the way).
Comment #12
David_Rothstein CreditAttribution: David_Rothstein commentedComment #13
gaurav.goyal CreditAttribution: gaurav.goyal commented9: 1988456_user_register_form_coding_standard_fix.patch queued for re-testing.
Comment #15
David_Rothstein CreditAttribution: David_Rothstein commentedLikely testbot glitch - moving back to RTBC.
Comment #16
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks!