The following piece of code does not follow the Coding Standards for indentation.

<?php
function user_register_form($form, &$form_state) {
  global
$user;
 
$admin = user_access('administer users');
 
// Pass access information to the submit handler. Running an access check
  // inside the submit function interferes with form processing and breaks
  // hook_form_alter().
 
$form['administer_users'] = array(
    
'#type' => 'value',
    
'#value' => $admin,
  );
?>
Files: 
CommentFileSizeAuthor
#3 update-coding-standard-for-user-module-1988456-2.patch554 byteseltermann
PASSED: [[SimpleTest]]: [MySQL] 40,369 pass(es).
[ View ]
#1 do-1988456-update-coding-standard-for-user-module.patch17.76 KBpvmchau
PASSED: [[SimpleTest]]: [MySQL] 40,335 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new17.76 KB
PASSED: [[SimpleTest]]: [MySQL] 40,335 pass(es).
[ View ]

Update coding standards for user.module

Status:Needs review» Needs work

+
+  // libxml2 ver.2.7.0 - 2.7.2 stripping leading angle brackets bug patch
+  if (
+      LIBXML_DOTTED_VERSION == '2.7.0' ||
+      LIBXML_DOTTED_VERSION == '2.7.1' ||
+      LIBXML_DOTTED_VERSION == '2.7.2' ||
+      (LIBXML_DOTTED_VERSION == '2.7.3' && version_compare(PHP_VERSION, '5.2.9', '<' ))
+  ) {
+    $data = str_replace('&lt;', '&#60;', $data);
+    $data = str_replace('&gt;', '&#62;', $data);
+    $data = str_replace('&amp;', '&#38;', $data);
+  }

I think you should remove those lines.

Status:Needs work» Needs review
StatusFileSize
new554 bytes
PASSED: [[SimpleTest]]: [MySQL] 40,369 pass(es).
[ View ]

Issue summary:View changes
Status:Needs review» Reviewed & tested by the community

Latest patch does apply indentions correctly.

Status:Reviewed & tested by the community» Needs work

Nope, oops... it needs to be two spaces of indentation, not one space :)

Assigned:Unassigned» graphityx