When i try create a task, the assigning people field is empty. And after clic on preview buttom these are the messages:

    Notice: Undefined property: stdClass::$organization_title in theme_pmtask_view() (line 91 of /home/user/user_site/sites/all/modules/pm/pmtask/pmtask.theme.inc).
    Notice: Undefined property: stdClass::$project_title in theme_pmtask_view() (line 98 of /home/user/user_site/sites/all/modules/pm/pmtask/pmtask.theme.inc).
    Notice: Undefined property: stdClass::$assigned_title in theme_pmtask_view() (line 145 of /home/user/user_site/sites/all/modules/pm/pmtask/pmtask.theme.inc).
    Notice: Undefined property: stdClass::$organization_title in theme_pmtask_view() (line 91 of /home/user/user_site/sites/all/modules/pm/pmtask/pmtask.theme.inc).
    Notice: Undefined property: stdClass::$project_title in theme_pmtask_view() (line 98 of /home/user/user_site/sites/all/modules/pm/pmtask/pmtask.theme.inc).
    Notice: Undefined property: stdClass::$assigned_title in theme_pmtask_view() (line 145 of /home/user/user_site/sites/all/modules/pm/pmtask/pmtask.theme.inc).

Thanks!

CommentFileSizeAuthor
#7 Create_task.png42.52 KBdbt102
#1 pm-task-assign.patch697 bytesjuliangb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juliangb’s picture

Status: Active » Needs review
FileSize
697 bytes

Here's a patch for review for the assignment empty issue.

For the preview issue, can you see the preview button? It is hidden by default (precisely because of issues such as these, I think).

dbt102’s picture

Applied patch to commit 77939bf on May 12, 2013. Patch applied cleanly.

Edited existing tasks by selecting from "Assigned To" drop down. Drop down was populated OK, task saved OK with task/person assignment now appearing ok.

Created new task for existing project and assigned task to existing person OK.

dbt102’s picture

Coder review of pmtask.module

"Coder found 1 projects, 8 files, 1 critical warnings, 132 normal warnings, 57 minor warnings, 0 warnings were flagged to be ignored"

The critical warning is in file /PMTASK/PMTASK.ADMIN.INC and reads... "Line 316: Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_fapi_markup]
}

juliangb’s picture

Status: Needs review » Postponed (maintainer needs more info)

Thanks for testing!

@dbt102, we're fixing those warnings en masse over at #1984336: Cleanup: Resolve Coder Warnings, but with a coder check on the patch files to make sure we don't introduce new ones (patch file can be copied into http://drupal-7.project-management-module.org/admin/config/development/c...).

For info, the critical warning found by coder is a false positive - as the $variable it talks about is already run through check_plain before this point.

I've committed this patch.

The only thing remaining here is to solve the other issue reported by @dvasquez, for which we need further info.

juliangb’s picture

Status: Postponed (maintainer needs more info) » Active

Reopening - there is a similar bug reported here: #1990196: Delete JavaScript files.

Bug screenshot

dbt102’s picture

I think I found an issue related to this one while testing #1987238-14: PMTask Migrating to Node grants

When creating a new task the "Assigned to" drop down box did not populate with any choices other than one for the signed in user. However, once the task was saved, the task could be edited, and the "Assigned to" drop down box is populated with expected choices. These could then be selected (reassigned) and it worked OK.

dbt102’s picture

FileSize
42.52 KB

When trying to reproduce the errors reported above, I came across a new one (see attached).

This one now comes up when first trying to Create a new Task.

My Git Terminal tells me "HEAD is now at f01b5bc Issue #2017915 by Raphael Durst"

juliangb’s picture

Title: Error Assigning people to Task » Warnings on node preview

#6:
- Fixed as part of #1994568-3: Warning on saving ticket

#7:
- The first message is expected and indicates that to create a task you need to specify a project - so need to create a project first.
- The second should be fixed as part of the patch at #1994568-3: Warning on saving ticket.

The only remaining issue here is warnings on node preview, which I propose to fix post alpha 1 (I will amend the roadmap).

juliangb’s picture

Status: Active » Fixed

Reviewing the issues list, I suggest we fix the node preview issues in this existing issue (I brought it over from the Storm issues queue) -> #377680: Support for node preview.

Therefore, marking this issue fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit eff01df on 7.x-1.x, 7.x-2.x by juliangb:
    Issue #1988600 by juliangb | dvasquez: Fixed Error Assigning people to...