Problem/Motivation

There is an 'addthis_configuration' alter hook in the addConfigurationOptionsJs() method of the Addthis class. This allows alteration of all the 'addthis_configuration' settings. Currently, the only value you can change in the 'addthis_share' variable is that of 'templates'. There are other things that can be added to the 'addthis_share' variable - namely the url shortener options.

Proposed resolution

Merge alterations from the 'addthis_configuration' hook ($configuration['templates'] and $configuration['addthis_share']) into a variable that will be assigned to the JS variable 'addthis_share'.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

labue’s picture

Possible solution

labue’s picture

Submitting new version without meta data

juampynr’s picture

Version: 7.x-4.0-alpha2 » 7.x-4.x-dev
Status: Active » Needs review
FileSize
1.08 KB

Patch does not apply. Re-rolling against 7.x-4.x.

More details about patching against a dev branch of a module can be found at http://drupal.org/project/addthis/git-instructions.

matglas86’s picture

New reroll against head.

matglas86’s picture

Here is some extra info for the api file to give instruction about the use of this alter.

matglas86’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
2.01 KB

I added some notes to the code. And will commit this.

  • Commit 65b1875 on 7.x-4.x by matglas86:
    Fixed issue #1989152 by matglas86, labue, juampy: Allow alterations to '...
matglas86’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.