The fact that makefiles are parsed bottom-up, means all overrides need to be at the top of our own makefile, and Panopoly with its sub-projects needs to be at the bottom of our own makefile.

Original Post

[edit:] Please ignore!

Trying to fix #1988570: FAPE causing "Illegal string offset 'field_name'" cost me hours of failure.
Currently I'm trying to track down the Drush bug #1621030: Regression for recursive makefiles. which still prevents us from overriding dependencies in panopoly_core.make

It would be really nice if you could apply the patch on a git checkout of openatrium and run Drush make.

What to do?

git clone --branch 7.x-2.x http://git.drupal.org/project/openatrium.git
cd openatrium
wget http://drupal.org/files/drush-oa2-concurrency-issue.patch
git apply drush-oa2-concurrency-issue.patch
./build.sh ../foo

How to tell?
It is expected that FAPE is checked out and correctly patched by openatrium.make, and later checked out again but not patched by panopoly_core.make.

You can tell either from the log output or from taking a look at ../foo/sites/all/modules/contrib/fape/fape.module. If the last function in the file is named:
function _fape_extract_entity_from_context($pane, $context)
then the file has been correctly patched. Otherwise it was overwritten.

Please also supply the drush version.
Whoever finds some time might play around with this and that, of course.
Thank you!

(I'm marking this a major task because there will again and again be dependencies that we want to patch.)

[edit:] Please ignore the patch, too!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pancho’s picture

Title: Track down Drush recursion bug » Help tracking down Drush recursion bug
Status: Active » Needs review
Pancho’s picture

Status: Needs review » Closed (works as designed)

See #1621030-11: Regression for recursive makefiles. :

Drush make traverses through the top level make file Bottom to top. So you should put your overwrites at the top.

So we need to restructure our makefile, to make it work.

Pancho’s picture

Title: Help tracking down Drush recursion bug » Make recursion work with our makefile
Category: task » bug
Status: Closed (works as designed) » Needs review
FileSize
10.12 KB

The fact that makefiles are parsed bottom-up, means all overrides need to be at the top of our own makefile, and Panopoly with its sub-projects needs to be at the bottom of our own makefile.

I checked this and it's true: All of our overrides never really worked.

Enclosed patch restructures our Makefile, so Panopoly is at the bottom and our overrides are at the top.
Doesn't change anything else.

Pancho’s picture

Reworded the note on recursion and fixed a blank line at EOF.
Also, postponed #1988570: FAPE causing "Illegal string offset 'field_name'" on this major issue here.

Pancho’s picture

Some very minor fixes:
Drush throws a notice when overwriting a git checkout by a regular release, so stick with git.

Pancho’s picture

Status: Needs review » Needs work

Currently throws an error on install.
I'll be right back with another version of the patch, but as I hit a few other bugs during investigation, I'm filing them first, so I don't forget them.

Pancho’s picture

Status: Needs work » Needs review
FileSize
10.07 KB

Keep file_entity at an older commit, because lately permissions were split per file type, screwing up both our and Panopoly's features.

mpotter’s picture

Status: Needs review » Fixed

This seems to work on my dev so committed to e07f7eb and I'll see what my automated tests show.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Update Issue Summary