Playlists

in the update function:

if (!db_field_exists('brightcove_player', 'param')) {
  $schema = brightcove_schema();
  db_add_field('brightcove_player', 'param', $schema['brightcove_player']['fields']['embed'] + array( 

We're adding a column called 'param', but in the schema we call it 'embed'. But this also brings up the issue that the name is a bit ambiguous. Can we instead call it (and the corresponding occurrences elsewhere in the patch) 'embed_parameter'.

-  // Perform basic extension check.
+  // Perform basic extension check,

???

       $resp = drupal_http_request($embedCode);
       if ($resp) {
-        $full_url = $resp->redirect_url;
-        $matches = NULL;
-        preg_match('#&bctid=([0-9]+)#i', $full_url, $matches);
-        if (isset($matches[1])) {
-          return file_stream_wrapper_uri_normalize(
-            "brightcove://{$matches[1]}");
-        }
+        $embedCode = $resp->redirect_url;
       }

This might be too much of an assumption. How about if ($resp && !empty($resp->redirect_url)) {

    $array = unserialize($setting->settings);
    if (!empty($array) && is_array($array)) {
      $array['video_player'] = $array['player'];
      unset($array['player']);
      $setting->settings = $array;
      drupal_write_record('file_display', $setting, 'name');
    }

I don't think this will work. there's an unserialize, but it doesn't get re-serialized.

+      '#video_id' => str_replace('/', '', parse_url($file->uri, PHP_URL_PATH)),

Is there any way to call the stream wrapper instead, because this is slightly different than its logic. May as well get $type that way too.

Otherwise this is great. Good to see that this could be done without making a new bundle of the File entity type (which might've broken other stuff in the Drupalverse that assumes videos are videos).

Marking this as "needs review" since it probably needs to be tested in a wider diversity of environments. But technically I think this is sound.

Only version 5 of the module will be supported in the future, so i move the issue to this version.

This version of the module is no longer supported. Only the latest 2 major versions are supported, which are currently 8.x-1.x and 7.x-6.x. Therefore I'm tagging this issue as 'unsupported' and closing it (won't fix). If this feature is business critical for your organization, please contact your Brightcove account manager for further support.