This drives me crazy. Especially "clone as Page" and "clone Foo".

CommentFileSizeAuthor
#4 views_ui-1992730-4.patch15.6 KBxjm
#4 interdiff-analyze.txt801 bytesxjm
#4 view_actions_after.png8.27 KBxjm
#4 display_actions_after.png43.24 KBxjm
#2 views_ui-1992730-2.patch14.82 KBxjm
#2 interdiff-sentence-case.txt10.17 KBxjm
sentence_case_dangit.patch5.28 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, sentence_case_dangit.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Assigned: Unassigned » xjm
Status: Needs work » Needs review
FileSize
interdiff-sentence-case.txt10.17 KB
views_ui-1992730-2.patch14.82 KB

Status: Needs review » Needs work

The last submitted patch, views_ui-1992730-2.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs work » Needs review
FileSize
display_actions_after.png43.24 KB
view_actions_after.png8.27 KB
interdiff-analyze.txt801 bytes
views_ui-1992730-4.patch15.6 KB

Here we go.

view_actions_after.png

display_actions_after.png

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Assigned: xjm » Unassigned
Status: Needs review » Reviewed & tested by the community

Yes, tested it on simplytest.me and works!

Is there any reason this drop button its text has more spacing on the left than ordinary dropbuttons?

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

Thanks @Bojhan! For the dropbutton styling, see #1781406: Use the new Core dropbutton .

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Title: Sentence case dropbutton actions in the Views UI » Sentence-case dropbutton actions in the Views UI
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Fixed » Reviewed & tested by the community

This commit doesn't appear anywhere in the git log, and the buttons are still cased incorrectly, so I think it must not have been pushed?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed bfd507f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.