Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See #1966246: [meta] Introduce specific annotations for each plugin type.
Note this issue is for Editor module, not the Edit module, whose issue is #1987140: Add a dedicated @InPlaceEditor plugin annotation.
Comment | File | Size | Author |
---|---|---|---|
#7 | editor_annotations-1992744.patch | 8.98 KB | quicksketch |
#5 | editor_annotations-1992744.patch | 8.98 KB | quicksketch |
#1 | editor_annotations-1992744.patch | 8.98 KB | quicksketch |
Comments
Comment #1
quicksketchStraightforward application of the pattern from #1986988-9: Add a dedicated @CKEditorPlugin annotation.
The only caveat was the necessity of aliasing on of the uses of "Editor" as a class name, since now both the annotation class Editor and the entity class Editor are competing for the same name. Aliasing the entity version made more sense to me and I figured it'd result in less magic than trying to alias an annotation plugin (if that's even possible), which would result in a renamed @EditorAnnotation or something like that.
Comment #3
quicksketch#1: editor_annotations-1992744.patch queued for re-testing.
Comment #5
quicksketchHm, fighting with
testbotGit today.Comment #7
quicksketchAh, damn. It's capitalization that's the problem. I should have seen that coming.
Comment #8
aspilicious CreditAttribution: aspilicious commentedLooking good....
Comment #9
quicksketchGood enough for RTBC? I'd like to get this in to match #1986988: Add a dedicated @CKEditorPlugin annotation so everything is in the same place for #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms.
Comment #10
aspilicious CreditAttribution: aspilicious commentedYes sir
Comment #11
Wim LeersRTBC +1
Comment #12
alexpottCommitted 96b2354 and pushed to 8.x. Thanks!
We need to ensure that any change notices are updated if they refer to editor plugins.
Comment #13
Wim LeersI updated http://drupal.org/node/1911614 to refer to the @Editor plugin annotation and to this issue.
Thanks! :)
Comment #14
alexpottUpdating title and priority