Review backwards compatibility

I totally forgot. Now we should be good to go.

(Already pushed to 7.x-2.x-dev, patch is for revision)

@Stevel there are 2 key aspects here.

1. Since the variables are in the settings.php there is no point in deleting them, they won't be removed unless the settings.php is edited.
2. @mrfelton feels that there should be support for the settings.php style. Many people have build on top of the settings.php style and we should be supporting them in the 7.x version.

1. +++ b/environment_indicator.install
   @@ -71,3 +71,36 @@
   +  $result = db_query("SELECT * FROM {variable} WHERE name LIKE 'environment_indicator_%'");
   

   This will wipe all variables, not just the old ones.

2. +++ b/environment_indicator.install
   @@ -71,3 +71,36 @@
   +  $result = db_query("SELECT * FROM {variable} WHERE name LIKE 'environment_indicator_%'");
   +  if (result) {
   ...
   +        case 'environment_indicator_color':
   ...
   +        case 'environment_indicator_text':
   ...
   +        case 'environment_indicator_enabled':
   +        case 'environment_indicator_margin':
   +        case 'environment_indicator_position':
   

   This conditions will never happen since the settings.php variables are not in the database.

I'm sorry to see that your effort will not be fixed, but if you feel like it I can help you find a nice ticket in the issue queue.

Thanks for your contribution!

1. +++ b/environment_indicator.install
   @@ -84,4 +84,45 @@ function environment_indicator_update_7201(&$sandbox) {
   +  $result = db_query("SELECT * FROM {variable} WHERE name LIKE 'environment_indicator_%'");
   +  if (result) {
   +    while ($row = $result->fetchAssoc()) {
   +      switch ($row['name']) {
   +        case 'environment_indicator_color':
   +          $default_environment->settings['color'] = unserialize($row['value']);
   +          variable_del($row['name']);
   +          break;
   +
   +        case 'environment_indicator_text':
   +          $default_environment->name = unserialize($row['value']);
   +          variable_del($row['name']);
   +          break;
   +
   +        case 'environment_indicator_enabled':
   +        case 'environment_indicator_margin':
   +        case 'environment_indicator_position':
   +          // This variable is no longer used. Remove it.
   +          variable_del($row['name']);
   +          break;
   +        case 'environment_indicator_suppress_pages':
   +          // This variable is still used, keep it.
   

   Instead do something like:

   $variable_names = array('environment_indicator_color', …);
   foreach ($variable_names as $variable_name) {
     $variable = variable_get($variable_name, NULL);
     if ($variable !== NULL) {
       …
     }
   }
   

2. +++ b/environment_indicator.install
   @@ -84,4 +84,45 @@ function environment_indicator_update_7201(&$sandbox) {
   +  // Only save if the default environment was not edited yet.
   +  if (! ($defaut_environment->export_type & EXPORT_IN_DATABASE)) {
   +    ctools_export_crud_save('environment_indicator_environment', $default_environment);
   +  }
   

   Move this chunk to the top so we don't run the previous code if we are not going to save it.

   I'm concerned about a possible data loss in the following scenario: the user edits the default environment, exports it to code in a feature, then runs the DB updates.

Reviewed and committed (http://drupalcode.org/project/environment_indicator.git/commit/d7a5c5a).

I added some update notification and corrected a typo result => $result