[D6] My Contacts

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxtavant1942668git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Changed Issue title. FYI: http://drupal.org/node/1011698

Few things that needs to be taken care of:
1. The issue summary points to the master branch on git. It should rather be
git clone --branch 6.x-1.x http://git.drupal.org/sandbox/tavant/1942668.git my_contacts

2. Also, there are still few errors that needs to be fixed.
http://ventral.org/pareview/httpgitdrupalorgsandboxtavant1942668git

Try and fix them, meanwhile I will go through the code and functionality.

Manual Review

• Remove the master branch. http://drupal.org/node/1127732
• You have many functions without comments: my_contacts_contact_directory_add_or_edit, my_contacts_contact_directory_form_validate, my_contacts_existence_email_id, my_contacts_upload_image_after_build, my_contacts_add_or_edit_contact_details and more.
• It uses "page arguments" instead of arg() to pass parameters to the callback. https://api.drupal.org/api/drupal/developer!hooks!core.php/function/hook...
  

  <?php
  /*
   * Implement menu hook
   */
  function my_contacts_menu() {
    $items['add-contact'] = array(
    'title' => 'Add Contact',
    'description' => t('Add Contact'),   //get the form contact_directory_add which is used to add contact
    'page callback' => 'drupal_get_form',
    'page arguments' => array('my_contacts_contact_directory_add_or_edit'),
    'access arguments' => array('access content'),
    'type' => MENU_CALLBACK,
    );
    $items['edit-contact/%'] = array(
    'title' => 'Edit Contact',
    'description' => t('Edit Contact'),
    'page callback' => 'drupal_get_form', //get the form contact_directory_edit which is used to edit contact
    'page arguments' => array('my_contacts_contact_directory_add_or_edit', 1), // 1 = cid
    'access arguments' => array('access content'),
    'type' => MENU_CALLBACK,
    );
  ...
  }
  
  ...
  /**
   * Add/Edit contact directory form.
   */
  function my_contacts_contact_directory_add_or_edit(&$form_state, $cid = NULL) {
  
  }
  
  ?>
  

• In my_contacts_contact_directory_add_or_edit $form is not defined.
• You have a small problem of vulnerability with the First Name, Last Name, Prefix Name...
  , if you write:<script>alert('First Name');</script> check it. https://drupal.org/node/28984

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.