The assert messages in testMenuTreeData() mention that "hyphens are changed to dashes", but hyphens and dashes are the same thing. It should be "changed to underscores".

<?php
   
// Validate that the - in main-menu is changed into an underscore
   
$this->assertEqual($output['1']['#theme'], 'menu_link__main_menu', 'Hyphen is changed to a dash on menu_link');
   
$this->assertEqual($output['#theme_wrappers'][0], 'menu_tree__main_menu', 'Hyphen is changed to a dash on menu_tree wrapper');
?>

This also occurs in D7.

Files: 
CommentFileSizeAuthor
#7 1993728-1-system-testmenutreedata_underscores_new.patch1.18 KBjohnmcc
PASSED: [[SimpleTest]]: [MySQL] 40,233 pass(es).
[ View ]
#1 1993728-1-system-testmenutreedata_underscores.patch1.28 KBpfrenssen
PASSED: [[SimpleTest]]: [MySQL] 55,548 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.28 KB
PASSED: [[SimpleTest]]: [MySQL] 55,548 pass(es).
[ View ]

Issue tags:+Novice

Adding tag, this is easy to review :)

Looks good, applies cleanly, and the relevant tests still pass.

The only thing I would suggest is that the other asserts in this test breach Drupal's coding standards for function calls. (They have a space between the parenthesis and the first argument.) This should probably be a new ticket though.

Yes indeed, I only corrected this in the lines that are relevant to this issue. The others should be fixed in another issue.

If you approve the patch, would you like to mark it as RTBC? :)

Status:Needs review» Reviewed & tested by the community

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Great catch!

Committed and pushed to 8.x. Thanks!

Back to 7.x.

Status:Patch (to be ported)» Needs review
StatusFileSize
new1.18 KB
PASSED: [[SimpleTest]]: [MySQL] 40,233 pass(es).
[ View ]

Here's a backport for 7.x.

Status:Needs review» Reviewed & tested by the community

Looks good!

Issue summary:View changes
Status:Reviewed & tested by the community» Fixed

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.