Main menu is broken on smaller screens in RTL and styles in general are not equivalent to the LTR styles.
Working on a patch.

Files: 
CommentFileSizeAuthor
#11 bartik_menu_tabs_rtl-1994192-11.patch4.14 KBmjohnq3
PASSED: [[SimpleTest]]: [MySQL] 55,854 pass(es).
[ View ]
#7 bartik_menu_tabs_rtl-1994192-7.patch2.59 KBtsi
PASSED: [[SimpleTest]]: [MySQL] 56,075 pass(es).
[ View ]
#6 bartik_menu_tabs_rtl-1994192-6.patch2.6 KBmjohnq3
PASSED: [[SimpleTest]]: [MySQL] 55,607 pass(es).
[ View ]
#6 interdiff.txt672 bytesmjohnq3
#4 bartik_menu_tabs_rtl-1994192-4.patch3.62 KBtsi
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch bartik_menu_tabs_rtl-1994192-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 bartik_menu_tabs_rtl.jpg43.57 KBmjohnq3
#3 bartik_menu_tabs_rtl-1994192-3.patch2.58 KBmjohnq3
PASSED: [[SimpleTest]]: [MySQL] 55,637 pass(es).
[ View ]
#3 interdiff.txt563 bytesmjohnq3
#1 bartik_menu_tabs_rtl-1994192-1.patch2.98 KBtsi
PASSED: [[SimpleTest]]: [MySQL] 55,360 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new2.98 KB
PASSED: [[SimpleTest]]: [MySQL] 55,360 pass(es).
[ View ]

Issue tags:+D8MI

StatusFileSize
new563 bytes
new2.58 KB
PASSED: [[SimpleTest]]: [MySQL] 55,637 pass(es).
[ View ]
new43.57 KB

This looks good except for one minor problem - no left padding on the main menu tabs. See attached screenshot and interdiff.txt.

StatusFileSize
new3.62 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch bartik_menu_tabs_rtl-1994192-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

The padding there should be (according to the LTR styles) padding: 0.7em 0.8em; and apply only under the min-width: 901px media query, this means we add a line to the RTL styles which looks the same as the LTR equivalent only for cascading reasons (patch attached). not perfect but maybe we have no choice.

Status:Needs review» Needs work

The last submitted patch, bartik_menu_tabs_rtl-1994192-4.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new672 bytes
new2.6 KB
PASSED: [[SimpleTest]]: [MySQL] 55,607 pass(es).
[ View ]

I'll take another crack at this. The affected css is now mobile-first.

StatusFileSize
new2.59 KB
PASSED: [[SimpleTest]]: [MySQL] 56,075 pass(es).
[ View ]
new2.59 KB
PASSED: [[SimpleTest]]: [MySQL] 55,723 pass(es).
[ View ]

There's a tab that snuck in there.
Besides that, seems like #6 does the same as #4 only that it is formatted better (mine got messed up by git) so it is fine by me.
This one removes the tab.

Status:Needs review» Reviewed & tested by the community

Tested the last patch, it works well.

Priority:Normal» Minor
Status:Reviewed & tested by the community» Needs work

Committed to 8.x. but I'd like us to clean up the comments. They are not very consistent.

+++ b/core/themes/bartik/css/style-rtl.cssundefined
@@ -70,9 +70,11 @@ ul.tips {
/* --------------- Secondary Menu ------------ */
@@ -249,6 +251,45 @@ ul.tips {
+/* ----------- media queries ------------------------------- */
...
+ /* ------------ Header and Menus -------------------------- */

To clarify @Dries' comment, the new hyphen-header things have more hyphens and the case is not consistent.

Status:Needs work» Needs review
StatusFileSize
new4.14 KB
PASSED: [[SimpleTest]]: [MySQL] 55,854 pass(es).
[ View ]

The hyphen-header thingies are now all title case and start at column #24. The ending "/" all end at column #62.

Status:Needs review» Needs work
Issue tags:-frontend, -D8MI

The last submitted patch, bartik_menu_tabs_rtl-1994192-11.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+frontend, +D8MI

Status:Needs review» Reviewed & tested by the community

Looks fine!

Status:Reviewed & tested by the community» Fixed

Committed b3b93ac and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.