On line 180 in tour.js we have the following line:

if ((itemId || itemClass) && $document.find('#' + itemId + ', .' + itemClass).length === 0) {

If "itemClass" or "itemId" are not provided we end up with something like "#, .foo" or "#foo, ." we need to check these individually.

Files: 
CommentFileSizeAuthor
#7 1995152-7-broken-selector.patch642 bytesnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 55,862 pass(es).
[ View ]
#4 1995152-4-broken-selector.interdiff.txt642 bytesnick_schuch
#4 1995152-4-broken-selector.patch827 bytesnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 56,461 pass(es).
[ View ]
#2 1995152-1-broken-selector.patch866 bytesnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 55,678 pass(es).
[ View ]

Comments

Issue tags:+JavaScript

tag

Status:Active» Needs review
StatusFileSize
new866 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,678 pass(es).
[ View ]

I have refreshed the logic to look for the itemId and/or itemClass first before checking the page.

I don't think we need the first line.

StatusFileSize
new827 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,461 pass(es).
[ View ]
new642 bytes

Right you are! Cheers!

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed 5a60cba and pushed to 8.x. Thanks!

Status:Fixed» Needs review
StatusFileSize
new642 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,862 pass(es).
[ View ]

This broke modal's. I must have had cache js while testing. :(

ok the condition looks better like that.

tag for sprint :)

Some steps to test #7:

1) Apply the patch in #7.
2) Apply the forum tour patch: https://drupal.org/node/1926296#comment-7445882
3) Enable the forum module.
4) Go to the "Add container" form for forum.
5) Start the tour. The first tip you should see if the a modal tip.

Status:Needs review» Reviewed & tested by the community
Issue tags:+Quick fix

Lets get this in

Status:Reviewed & tested by the community» Fixed

Committed ae1116d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Update description.