Namely when using the overlay module, the ID's of submit buttons can vary. i.e if you have 3 forms on the page then the ID of the submit button becomes edit-submit--2.

The 'file add' form explicitly checks for 'edit-submit', if it doesn't match the form will never save. Attached is a patch to fix this.

CommentFileSizeAuthor
#2 file_entity-1995294-2.patch950 bytesmauritsl
file_entity-file-add-overlay-fix.patch974 bytesPaul Lomax
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, file_entity-file-add-overlay-fix.patch, failed testing.

mauritsl’s picture

mauritsl CreditAttribution: mauritsl commented
Status: Needs work » Needs review
FileSize
file_entity-1995294-2.patch950 bytes

Rerolled patch with latest rev.

aaron’s picture

aaron CreditAttribution: aaron commented
Status: Needs review » Reviewed & tested by the community

I am unable to reproduce the original issue, but looking at the code it seems sound. Additionally, running it doesn't break the site.

aaron’s picture

aaron CreditAttribution: aaron commented

#2: file_entity-1995294-2.patch queued for re-testing.

aaron’s picture

aaron CreditAttribution: aaron commented
Status: Reviewed & tested by the community » Fixed

Committed to http://drupalcode.org/project/file_entity.git/commit/46279e2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.