Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The Topics have been created as specific project, but still all node types add their own Topics implementation. This leads to problems, like this: #1960694: Questions are missing the "Topics" field.
I'm now having issues with the Topics field being in a collapsed box on the node/add/event but it misses the fieldset on node/add/document.
Can we add it dynamic on all commons_files_entity_types? The Commons Topics module already has the field_base, but misses the field_instances.
I'll add a patch that will add this field separate, just like the og_content_access field.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1995508-1-seperate-topics-topics.patch | 5.36 KB | BarisW |
| #1 | 1995508-1-seperate-topics-documents.patch | 2.39 KB | BarisW |
| #1 | 1995508-1-seperate-topics-events.patch | 5.77 KB | BarisW |
| #1 | 1995508-1-seperate-topics-groups.patch | 2.83 KB | BarisW |
| #1 | 1995508-1-seperate-topics-polls.patch | 2.06 KB | BarisW |
Comments
Comment #1
BarisW CreditAttribution: BarisW commentedHere's what I've done:
- Added a way to add the topic field to all nodes types that implemented hook_commons_entity_integration(), except those that have set 'exclude_topics' to TRUE.
- Moved the field instance creation from commons_groups to commons_topics.
- Removed all field instances from the current entity types.
- Moved the topics form alter and JS to the commons_topics module.
- Added depencies to commons types that use topics.
Comment #2
jpontani CreditAttribution: jpontani commentedReviewing now. Related to #1960694: Questions are missing the "Topics" field. Going to mark that as a duplicate of this, since it will be fixed when this is committed.
Comment #3
jpontani CreditAttribution: jpontani commentedTested on both a fresh install and from upgrading from 3.2, worked great for me. I did make a slight change to the QA patch, by removing the exclude call since we need the topics field on Questions.
Committed to dev branches.
http://drupalcode.org/project/commons_polls.git/commit/4b296c5
http://drupalcode.org/project/commons_wikis.git/commit/a9413db
http://drupalcode.org/project/commons_posts.git/commit/4b3cc8b
http://drupalcode.org/project/commons_documents.git/commit/a8afad6
http://drupalcode.org/project/commons_q_a.git/commit/580c51b
http://drupalcode.org/project/commons_groups.git/commit/9c1127b
http://drupalcode.org/project/commons_topics.git/commit/7885ea2
http://drupalcode.org/project/commons_events.git/commit/e512013
Comment #4
jpontani CreditAttribution: jpontani commentedForgot to add in a features pipe alter. We want to prevent the topics field instances from being exported to new features since it's being added dynamically.
http://drupalcode.org/project/commons_topics.git/commit/c6620a0