Twitter Block intercepts calls to delete some other blocks [#1996978]

Current 2.x-dev has a bug where custom blocks created by any other module that uses a delete URL matching...
admin/structure/block/administer/%/%/delete
... may not be able to be deleted because Twitter Block intercepts the call and presents the confirmation page to delete the Twitter block rather than the desired block.

Comment	File	Size	Author
#3	twitter_block-intercepts-delete-other-blocks-1996978-3.patch	1.78 KB	Devin Carlson
#3
#1	twitter_block-intercepts-delete-other-blocks-1996978-1.patch	494 bytes	matthewandrews
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

matthewandrews CreditAttribution: matthewandrews commented 17 May 2013 at 06:53

File	Size
twitter_block-intercepts-delete-other-blocks-1996978-1.patch	494 bytes

Here's a patch.

Comment #2

Devin Carlson CreditAttribution: Devin Carlson commented 1 June 2013 at 11:23

Status:

Active

» Needs review

Comment #3

Devin Carlson CreditAttribution: Devin Carlson commented 5 July 2013 at 02:43

File	Size
twitter_block-intercepts-delete-other-blocks-1996978-3.patch	1.78 KB

Good catch and thanks for the patch!

I think that, since the $module page argument is being hardcoded, we might as well hardcode it in twitter_block_delete() as well and get rid of the $module argument altogether.